-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The incoming request has too many parameters. This server supports a maximum of 2100 parameters. #26361
Comments
Which database are you using? |
I'm sure it's one of the |
ms sqlserver , thank you. |
I think ,when select all repos, the .in sql string shoud be " not in (null)" rather then " in (id1,id2,id3.....ids)". |
I think it's pointless to discuss this, in some cases I only want to view the two I care about inside the 10,000 repos, but in other cases I only want to view the other repos inside the 10,000 repos other than those two. It's hard to tell which is more important, |
" not in (null)" means select all, or default show all if you need reach "view something or view other", it is best to add checkbox before repo list. |
If you have a good solution to fix this, you can initiate a PR @zjjhot |
I'm not good at golang ⊙﹏⊙。Very thanks for every contributor. |
visit this url : http://your-gitea-url/issues?state=closed&q= I EVEN NOT input repos id param in the url string..., that just only 1 param is : state=closed. so , what happend .... ⊙﹏⊙ |
The issue is with the DB parameters rather than Web. I was exploring some actions we can take to solve this problem. RAW sql IN statements seems feasible but it would have some limit for different DBMS and as of my search for large lists it can have some performance impact (not so sure about it I need to study more this). What if we try to create a temporary table to store those issues IDS coming from Also Im with trouble to reproduce this bug. In my local gitea instance Im not even close to 2100 issues. Is there a way to reproduce this bug locally? |
Migrating Gitea to local with issues. Then you will get 2k+ opening issues and 9k+ closed issues. |
Any one can help to fix this 😕 |
|
I don't think it's a regression. The query was not changed.
|
This PR has multiple parts, and I didn't split them because it's not easy to test them separately since they are all about the dashboard page for issues. 1. Support counting issues via indexer to fix #26361 2. Fix repo selection so it also fixes #26653 3. Keep keywords in filter links. The first two are regressions of #26012. After: https://github.com/go-gitea/gitea/assets/9418365/71dfea7e-d9e2-42b6-851a-cc081435c946 Thanks to @CaiCandong for helping with some tests.
Description
visit http://giteaurl/issues
then click "Closed" tab on right side
there is an error page displayed 500 internal error,and in log file:The incoming request has too many parameters. This server supports a maximum of 2100 parameters. Please reduce the number of parameters and resend the request.
This is due to the default selection behavior of the issues page, as there are too many repos passed in later on &repos=...
There are differences in the concepts of between "select all repos " and "select every repo"
If 'select all' is understood as' select everything ', then&repos=.... Later, if there are 1000+ repos, then 1000+ parameters need to be passed in ...
Gitea Version
1.21.0+dev-892-g8e8f55839
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
1.21.0+dev-892-g8e8f55839
Operating System
windows
How are you running Gitea?
windows exe
Database
None
The text was updated successfully, but these errors were encountered: