-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix counting and filtering on the dashboard page for issues #26657
Conversation
This reverts commit 7693267.
Thank you very much. I have a suggestion. Issues that have existed in history can be displayed in the repo list (even if this issue module is prohibited from accessing, it is reasonable to exist, and I can always see records of historical existence, which is fine). However, those that have never been issued (count=0) should not be displayed in the repo list, especially those repos that disabled by issue module. |
Not sure, maybe another PR.
Done in e56c59a |
Maybe we can use https://pkg.go.dev/maps@go1.21.0#DeleteFunc |
Not now, Gitea is still using go1.20: Line 3 in 1432d4e
|
* giteaofficial/main: Fix counting and filtering on the dashboard page for issues (go-gitea#26657) add mfa doc (go-gitea#26654) [Refactor] getIssueStatsChunk to move inner function into own one (go-gitea#26671) Use line-height: normal by default (go-gitea#26635) Improve repo sub menu (go-gitea#26531) Fix organization list in dashboard (go-gitea#26650)
This PR actually has multiple parts, and I didn't split them because it's not easy to test them separately since they are all about the dashboard page for issues.
The first two are regressions of #26012.
After:
Screen.Recording.2023-08-22.at.17.51.28.mov
Thanks to @CaiCandong for helping with some tests.