The code comment dispeared after resolving/unresolving a comment #28949
Comments
|
Can you provide the URL? |
|
I can see it on my phone. |
|
Maybe the reason is: "ShowOutdatedComments" defaults to "false", so you won't see the "outdated" comments.
Maybe it actually should default to true.
|
|
But the experience is very odd when I click the |
Even if it doesn't disappear by clicking "resolve the conversation", it would also disappear when you refresh the page. Indeed it is a design problem. Maybe it should tell the user that "The outdated comment won't show" on the UI. |
|
-> Improve user experience for outdated comments #29050 |
Try to improve #28949 1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings consistent user experience, and sometimes the "outdated (source changed)" comments are still valuable. 2. Show a friendly message if the comment won't show, then the end users won't fell that "the comment disappears" (it is the special case when `ShowOutdatedComments = false`)
Try to improve go-gitea#28949 1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings consistent user experience, and sometimes the "outdated (source changed)" comments are still valuable. 2. Show a friendly message if the comment won't show, then the end users won't fell that "the comment disappears" (it is the special case when `ShowOutdatedComments = false`)
Backport #29050 by wxiaoguang Try to improve #28949 1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings consistent user experience, and sometimes the "outdated (source changed)" comments are still valuable. 2. Show a friendly message if the comment won't show, then the end users won't fell that "the comment disappears" (it is the special case when `ShowOutdatedComments = false`) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Try to improve go-gitea#28949 1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings consistent user experience, and sometimes the "outdated (source changed)" comments are still valuable. 2. Show a friendly message if the comment won't show, then the end users won't fell that "the comment disappears" (it is the special case when `ShowOutdatedComments = false`)
|
Automatically locked because of our CONTRIBUTING guidelines |
Description
The code comment dispeared after resolving/unresolving a comment
Gitea Version
main
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
Git Version
No response
Operating System
No response
How are you running Gitea?
gitea.com
Database
None
The text was updated successfully, but these errors were encountered: