Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user experience for outdated comments (#29050) #29086

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Feb 8, 2024

Backport #29050 by wxiaoguang

Try to improve #28949

  1. Make ctx.Data["ShowOutdatedComments"] = true by default: it brings consistent user experience, and sometimes the "outdated (source changed)" comments are still valuable.
  2. Show a friendly message if the comment won't show, then the end users won't fell that "the comment disappears" (it is the special case when ShowOutdatedComments = false)

Try to improve go-gitea#28949

1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings
consistent user experience, and sometimes the "outdated (source
changed)" comments are still valuable.
2. Show a friendly message if the comment won't show, then the end users
won't fell that "the comment disappears" (it is the special case when
`ShowOutdatedComments = false`)
@GiteaBot GiteaBot added topic/ux How users interact with Gitea type/enhancement An improvement of existing functionality labels Feb 8, 2024
@GiteaBot GiteaBot requested a review from lunny February 8, 2024 01:50
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 8, 2024
@GiteaBot GiteaBot added this to the 1.21.6 milestone Feb 8, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 8, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) February 8, 2024 01:56
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 8, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2024
@wxiaoguang wxiaoguang merged commit c9b2aae into go-gitea:release/v1.21 Feb 8, 2024
26 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/ux How users interact with Gitea type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants