Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copying a code block line contains a trailing newline #29012

Closed
drifter75 opened this issue Feb 1, 2024 · 2 comments · Fixed by #29019
Closed

Copying a code block line contains a trailing newline #29012

drifter75 opened this issue Feb 1, 2024 · 2 comments · Fixed by #29019
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Milestone
1.21.6

Comments

@drifter75
Copy link

drifter75 commented Feb 1, 2024 •
edited by delvh
Loading

Description

when you copy a code block using the copy button it results in a trailing new line.

https://try.gitea.io/andrewimeson/actions_schedule

Gitea Version

1.21.4

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

using docker

Database

PostgreSQL
@silverwind
Copy link
Member

silverwind commented Feb 1, 2024 •
edited
Loading

IIRC this was done because it previously matched GitHub behaviour, but I see GitHub had changed it to remove the newline, so we should follow suit.

@silverwind silverwind added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Feb 1, 2024
silverwind added a commit to silverwind/gitea that referenced this issue Feb 1, 2024
@silverwind
Strip trailing newline in markdown code copy
7af6305 
Fixes: go-gitea#29012
@silverwind silverwind mentioned this issue Feb 1, 2024
Merged
@GiteaBot GiteaBot mentioned this issue Feb 1, 2024
Merged
@lunny lunny added this to the 1.21.6 milestone Feb 2, 2024
@github-actions GitHub Actions
Copy link

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Milestone
1.21.6
Development

Successfully merging a pull request may close this issue.

Strip trailing newline in markdown code copy silverwind/gitea
3 participants
@lunny @silverwind @drifter75