Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip trailing newline in markdown code copy (#29019) #29022

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Feb 1, 2024

Backport #29019 by @silverwind

Fixes: #29012

Behaviour now matches GH. Safeguard added in the for loop because textContent may be null in which case it does not make sense to render the copy button.

Behaviour now matches GH. Safeguard added in the for loop because
`textContent` may be null in which case it does not make sense to render
the copy button.
@GiteaBot GiteaBot added modifies/frontend type/enhancement An improvement of existing functionality labels Feb 1, 2024
@GiteaBot GiteaBot added this to the 1.21.5 milestone Feb 1, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 1, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 1, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 1, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 1, 2024
@jolheiser jolheiser enabled auto-merge (squash) February 1, 2024 21:04
@jolheiser jolheiser merged commit 5d1abdc into go-gitea:release/v1.21 Feb 1, 2024
26 checks passed
@lunny lunny modified the milestones: 1.21.5, 1.21.6 Feb 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants