Implement "env" command for internal ssh #6889
Labels
type/enhancement
An improvement of existing functionality
type/proposal
The new feature has not been accepted yet but needs to be discussed first.
Comments
sapk
added a commit
to sapk-fork/gitea
that referenced
this issue
May 9, 2019
Needed fix described in issue go-gitea#6889
techknowlogick
pushed a commit
that referenced
this issue
May 9, 2019
* ssh: ignore env command totally * Remove commented code Needed fix described in issue #6889
lunny
added
type/enhancement
zeripath
pushed a commit
to zeripath/gitea
that referenced
this issue
May 11, 2019
* ssh: ignore env command totally * Remove commented code Needed fix described in issue go-gitea#6889
techknowlogick
pushed a commit
that referenced
this issue
May 11, 2019
* Add options to git.Clone to make it more capable * Begin the process of removing the local copy and tidy up * Remove Wiki LocalCopy Checkouts * Remove the last LocalRepo helpers * Remove WithTemporaryFile * Enable push-hooks for these routes * Ensure tests cope with hooks Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove Repository.LocalCopyPath() * Move temporary repo to use the standard temporary path * Fix the tests Signed-off-by: Andrew Thornton <art27@cantab.net> * Remove LocalWikiPath * Fix missing remove Signed-off-by: Andrew Thornton <art27@cantab.net> * Use AppURL for Oauth user link (#6894) * Use AppURL for Oauth user link Fix #6843 * Update oauth.go * Update oauth.go * internal/ssh: ignore env command totally (#6825) * ssh: ignore env command totally * Remove commented code Needed fix described in issue #6889 * Escape the commit message on issues update and title in telegram hook (#6901) * update sdk to latest (#6903) * improve description of branch protection (fix #6886) (#6906) The branch protection description text were not quite accurate. * Fix logging documentation (#6904) * ENABLE_MACARON_REDIRECT should be REDIRECT_MACARON_LOG * Allow DISABLE_ROUTER_LOG to be set in the [log] section * [skip ci] Updated translations via Crowdin * Move sdk structs to modules/structs (#6905) * move sdk structs to moduels/structs * fix tests * fix fmt * fix swagger * fix vendor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we ignore env passed via SSH. This even create some bug on windows without env local command.
We need to (re-)implement the part (that did nothing) disabled in #6825 via filling an array of env variable to be set to cmd.Env for later call of exec.
The tricky part of this implemntation is that we should filter and sanitize some variables and input passed to this command.
If you think of env variable that we should filter, please comment this issue.
The text was updated successfully, but these errors were encountered: