Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local clones & make hooks run on merge/edit/upload #6672

Merged
merged 27 commits into from
May 11, 2019

Conversation

zeripath
Copy link
Contributor

This PR removes the local clones from the Wiki and the Repository.

It also fixes #6544 by ensuring that the hooks are run on pushing.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath
Copy link
Contributor Author

This is a redo of the closed #6505

I've not moved over the improvement to tree as that will conflict with @filipnavara's git patches and I haven't reduced temporary repo to a shim as previously.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 18, 2019
@codecov-io
Copy link

codecov-io commented Apr 20, 2019

Codecov Report

Merging #6672 into master will increase coverage by 0.04%.
The diff coverage is 42.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6672      +/-   ##
==========================================
+ Coverage   41.38%   41.43%   +0.04%     
==========================================
  Files         436      440       +4     
  Lines       59618    59738     +120     
==========================================
+ Hits        24674    24752      +78     
- Misses      31704    31750      +46     
+ Partials     3240     3236       -4
Impacted Files Coverage Δ
routers/repo/branch.go 57.83% <ø> (+1.22%) ⬆️
models/user.go 50.92% <ø> (-0.14%) ⬇️
modules/setting/repository.go 51.42% <ø> (ø) ⬆️
modules/git/repo_tree.go 41.26% <0%> (-39.99%) ⬇️
modules/git/repo_object.go 0% <0%> (ø)
modules/git/repo_index.go 0% <0%> (ø)
modules/git/repo.go 59.06% <100%> (-5.11%) ⬇️
models/repo.go 47.67% <100%> (-0.15%) ⬇️
modules/git/repo_branch.go 82.17% <100%> (ø) ⬆️
modules/repofiles/temp_repo.go 70.5% <33.33%> (-1.11%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34eee25...1dcd2de. Read the comment docs.

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Apr 20, 2019
@lafriks lafriks added this to the 1.9.0 milestone Apr 20, 2019
@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 23, 2019
@zeripath zeripath changed the title Remove local clones & fix #6544 Remove local clones & make hooks run on merge/edit/upload May 9, 2019
@lafriks
Copy link
Member

lafriks commented May 11, 2019

please resolve conflicts but otherwise lgtm

techknowlogick and others added 2 commits May 11, 2019 12:27
* Use AppURL for Oauth user link

Fix go-gitea#6843

* Update oauth.go

* Update oauth.go
* ssh: ignore env command totally

* Remove commented code 

Needed fix described in issue go-gitea#6889
zeripath and others added 7 commits May 11, 2019 12:27
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 11, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 11, 2019
@techknowlogick techknowlogick merged commit ce8de35 into go-gitea:master May 11, 2019
@zeripath zeripath deleted the remove-local-clones branch May 12, 2019 19:56
@lafriks lafriks mentioned this pull request May 15, 2019
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding tag in the background can't trigger hook
8 participants