-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit label list height on edit issue page #10216
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10216 +/- ##
==========================================
+ Coverage 43.62% 43.66% +0.03%
==========================================
Files 576 582 +6
Lines 79716 80045 +329
==========================================
+ Hits 34778 34952 +174
- Misses 40639 40757 +118
- Partials 4299 4336 +37
Continue to review full report at Codecov.
|
This also happens on the assignees on 1.11.0. I assume it's the same behaviour for labels but we don't have many... I think this should be backported, I'm happy to make a PR. |
as @proton-ab said i copied this rule from @lafriks marked as resolved. so i need to do anything? @jamesorlakin ofcourse you can make a backport after merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's OK to maintain the 300px value for consistency, but perhaps we should change them all to a relative height in a future PR.
This one LGTM 👍
Having had a closer look while creating a backport, I'm not sure this will also fix a long assignments list as well. The extra CSS property is only assigned to the label selector, whereas the underlined selector is common between the two ( |
@jamesorlakin can you send a pr? |
Sure, I'll make a PR against master and then experiment with backporting it 👍 |
Before was no limit:
After: