Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix margin for referenced issue title #11623

Closed
wants to merge 2 commits into from
Closed

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 25, 2020

Unsure if this is correct way to do it.

Before:
firefox_2020-05-25_21-15-44

After:
firefox_2020-05-25_21-16-03

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label May 25, 2020
@lafriks lafriks added this to the 1.13.0 milestone May 25, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 25, 2020
@silverwind
Copy link
Member

silverwind commented May 25, 2020

I guess you could also align to the left side of the image, like GitHub does. At least there'd be less wasted space that way. Maybe even reduce avatar size slightly.

@CirnoT
Copy link
Contributor Author

CirnoT commented May 26, 2020

I could reduce the avatar size to 20x20px, just like GitHub does.

Would need few minor tweaks and removal of one padding hack but I'd prefer to wait for #11589 to get merged first, otherwise it looks rather weird with round avatars.

chrome_2020-05-26_02-24-23

@CirnoT CirnoT marked this pull request as draft May 26, 2020 00:26
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 27, 2020
@CirnoT CirnoT closed this May 29, 2020
@CirnoT CirnoT deleted the issue-ref branch May 29, 2020 22:19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants