Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix align issues and decrease avatar size on PR timeline #11689

Merged
merged 7 commits into from
Jun 6, 2020
Merged

Fix align issues and decrease avatar size on PR timeline #11689

merged 7 commits into from
Jun 6, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 29, 2020 •
edited
Loading

Extension on #11623; as per #11623 (comment)

chrome_2020-05-30_00-15-46

chrome_2020-05-30_00-18-53

chrome_2020-05-30_00-19-14

  • Few vertical align issues solved and hacks removed
  • Referenced issue title aligned to avatar
  • Reduced avatar size on timeline to 20px (same as GitHub)

@silverwind
Copy link
Member

Maybe increase the margin between timeline icon and avatar/text slightly. It looks a bit crammed.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 30, 2020
@CirnoT
Copy link
Contributor Author

CirnoT commented May 30, 2020

Don't agree actually, and In fact it was not changed at all from what we have now.

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label May 30, 2020
silverwind
silverwind approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess it's actually fine

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 30, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 6, 2020
@zeripath zeripath added this to the 1.13.0 milestone Jun 6, 2020
@lafriks
Copy link
Member

lafriks commented Jun 6, 2020

Make lgtm work

@zeripath zeripath merged commit f6315fb into go-gitea:master Jun 6, 2020
@CirnoT CirnoT deleted the issue-timeline branch June 6, 2020 22:03
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT
Fix align issues and decrease avatar size on PR timeline (go-gitea#11689
29cb97d 
)

* Fix margin for referenced issue title

* Change avatar size to 20px, align referenced issue title to avatar

* better align
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@lafriks lafriks lafriks approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
7 participants
@CirnoT @silverwind @lafriks @mrsdizzie @lunny @zeripath @GiteaBot