Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] convert team(s) to apiTeam(s) #13745

Merged
merged 16 commits into from
May 13, 2022
Merged

[Refactor] convert team(s) to apiTeam(s) #13745

merged 16 commits into from
May 13, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 29, 2020

as title

@6543 6543 added modifies/api This PR adds API routes or modifies them type/refactoring Existing code has been cleaned up. There should be no new functionality. pr/wip This PR is not ready for review labels Nov 29, 2020
@6543 6543 mentioned this pull request Nov 29, 2020
Merged
3 tasks
@6543 6543 added this to the 1.15.0 milestone Jan 27, 2021
@techknowlogick techknowlogick modified the milestones: 1.15.0, 1.16.0 Jun 15, 2021
delvh
delvh reviewed Oct 21, 2021
View reviewed changes
modules/convert/convert.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 21, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 23, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 23, 2021
lunny
lunny previously requested changes Oct 23, 2021
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI failure.

@6543
Copy link
Member Author

6543 commented Oct 24, 2021

Just a reminder this pull is still WIP ... if somebody like to take over ... just do

@lunny lunny modified the milestones: 1.16.0, 1.17.0 Nov 9, 2021
@6543 6543 requested a review from lunny May 12, 2022 22:25
@6543 6543 removed the pr/wip This PR is not ready for review label May 12, 2022
@6543
Copy link
Member Author

6543 commented May 12, 2022

@lunny e150269 caused the ci failure

@lunny lunny dismissed their stale review May 13, 2022 15:25

ci successful

@6543 6543 merged commit b135313 into go-gitea:main May 13, 2022
@6543 6543 deleted the refactor_teams-to-api-convert branch May 13, 2022 17:28
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 14, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
79092b0 
* giteaofficial/main:
  Fix duplicate entry error when add team member (go-gitea#19702)
  [Refactor] convert team(s) to apiTeam(s) (go-gitea#13745)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@6543 @AbdulrhmnGhanem
[Refactor] convert team(s) to apiTeam(s) (go-gitea#13745)
4cfa11c 
* Refactor: teams to api convert

* make org load optional

* more info in tests
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@lunny lunny Awaiting requested review from lunny

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@6543 @lunny @wxiaoguang @delvh @techknowlogick @GiteaBot