Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] List, Check, Add & delete endpoints for repository teams #13630

Merged
merged 13 commits into from
Feb 1, 2021
Merged

[API] List, Check, Add & delete endpoints for repository teams #13630

merged 13 commits into from
Feb 1, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 19, 2020 •
edited
Loading

@6543 6543 added modifies/api This PR adds API routes or modifies them type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Nov 19, 2020
6543
6543 commented Nov 19, 2020
View reviewed changes
routers/api/v1/repo/teams.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 19, 2020
6543
6543 commented Nov 19, 2020
View reviewed changes
routers/api/v1/api.go Outdated Show resolved Hide resolved
@6543 6543 added this to the 1.14.0 milestone Nov 24, 2020
@6543 6543 mentioned this pull request Nov 24, 2020
Open
7 tasks
@codecov-io
Copy link

codecov-io commented Nov 29, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5e20fd6). Click here to learn what that means.
The diff coverage is 62.16%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #13630   +/-   ##
=========================================
  Coverage          ?   42.21%           
=========================================
  Files             ?      763           
  Lines             ?    81312           
  Branches          ?        0           
=========================================
  Hits              ?    34324           
  Misses            ?    41391           
  Partials          ?     5597
Impacted Files Coverage Δ
routers/api/v1/repo/teams.go 58.82% <58.82%> (ø)
routers/api/v1/api.go 78.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e20fd6...6d9ddc0. Read the comment docs.

@6543 6543 marked this pull request as ready for review November 29, 2020 12:57
@lunny
Copy link
Member

lunny commented Jan 27, 2021

Please resolve the conflicts

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 1, 2021
@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 1, 2021
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Feb 1, 2021
@6543 6543 merged commit 6d27703 into go-gitea:master Feb 1, 2021
@6543 6543 deleted the api_repo-teams branch February 1, 2021 21:57
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Feb 2, 2021
@a1012112796
Merge branch 'master' into empty_pr
16ff24f 
* master:
  Changelog v1.13.2 (go-gitea#14535) (go-gitea#14543)
  [skip ci] Updated translations via Crowdin
  [API] List, Check, Add & delete endpoints for repository teams (go-gitea#13630)
  [skip ci] Updated translations via Crowdin
  rm redirect (go-gitea#14534)
  Upgrade 'css-minimizer-webpack-plugin' to the latest version (go-gitea#14527)
  Set the name Mapper in migrations (go-gitea#14526)
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Feb 3, 2021
@a1012112796
Merge branch 'master' into feature/dismissing_reviews
d017a10 
* master: (28 commits)
  [Docs] Clone filters (go-gitea#14555)
  update docs to show latest stable version (1.13.2) (go-gitea#14550)
  Adding Chi's GetHead middleware (go-gitea#14541)
  Changelog v1.13.2 (go-gitea#14535) (go-gitea#14543)
  [skip ci] Updated translations via Crowdin
  [API] List, Check, Add & delete endpoints for repository teams (go-gitea#13630)
  [skip ci] Updated translations via Crowdin
  rm redirect (go-gitea#14534)
  Upgrade 'css-minimizer-webpack-plugin' to the latest version (go-gitea#14527)
  Set the name Mapper in migrations (go-gitea#14526)
  Internal ssh server respect Ciphers, MACs and KeyExchanges settings (go-gitea#14523)
  Move middlewares to web/middleware (go-gitea#14480)
  Add Doctor FixWrongUserType (go-gitea#14522)
  [skip ci] Updated translations via Crowdin
  noop (go-gitea#14521)
  Update docs and comments to remove macaron (go-gitea#14491)
  [skip ci] Updated translations via Crowdin
  Fix json charset bug (go-gitea#14514)
  enhancement: add signoff option in commit form (go-gitea#14516)
  Fix load time bug (go-gitea#14508)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@khmarbaise khmarbaise khmarbaise approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

[API] List repository teams
5 participants
@6543 @codecov-io @lunny @khmarbaise @GiteaBot