Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change migration 168 to no-op #14521

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Change migration 168 to no-op #14521

merged 2 commits into from
Jan 29, 2021

Conversation

jolheiser
Copy link
Member

A new migration should be provided for the intended fix.

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@jolheiser jolheiser added type/bug topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them labels Jan 29, 2021
@jolheiser jolheiser added this to the 1.14.0 milestone Jan 29, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 29, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 29, 2021
@6543
Copy link
Member

6543 commented Jan 29, 2021

best sol to not break more ...

@lunny lunny merged commit e92552a into go-gitea:master Jan 29, 2021
@jolheiser jolheiser deleted the 168-noop branch January 29, 2021 15:56
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 29, 2021
@jpraet
Copy link
Member

jpraet commented Feb 2, 2021

Shouldn't this have been backported to 1.13? The broken v168 migration is included in 1.13.2.

@6543
Copy link
Member

6543 commented Feb 2, 2021

@jpraet It's not. Migrations dont get backported at all.

Just the fix for the migration & a workaround where backported witch work fine

a1012112796 added a commit to a1012112796/gitea that referenced this pull request Feb 3, 2021
* master: (28 commits)
  [Docs] Clone filters (go-gitea#14555)
  update docs to show latest stable version (1.13.2) (go-gitea#14550)
  Adding Chi's GetHead middleware (go-gitea#14541)
  Changelog v1.13.2 (go-gitea#14535) (go-gitea#14543)
  [skip ci] Updated translations via Crowdin
  [API] List, Check, Add & delete endpoints for repository teams (go-gitea#13630)
  [skip ci] Updated translations via Crowdin
  rm redirect (go-gitea#14534)
  Upgrade 'css-minimizer-webpack-plugin' to the latest version (go-gitea#14527)
  Set the name Mapper in migrations (go-gitea#14526)
  Internal ssh server respect Ciphers, MACs and KeyExchanges settings (go-gitea#14523)
  Move middlewares to web/middleware (go-gitea#14480)
  Add Doctor FixWrongUserType (go-gitea#14522)
  [skip ci] Updated translations via Crowdin
  noop (go-gitea#14521)
  Update docs and comments to remove macaron (go-gitea#14491)
  [skip ci] Updated translations via Crowdin
  Fix json charset bug (go-gitea#14514)
  enhancement: add signoff option in commit form (go-gitea#14516)
  Fix load time bug (go-gitea#14508)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/repo-migration Migrate repos from other platforms to Gitea, or from Gitea to them type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants