API: fix set milestone on PR creation #14981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr creation via API failed with 404, because we searched for milestoneID 0, due to uninitialized var usage D:
noerw
added
backport/v1.13
modifies/api
6543
reviewed
Mar 13, 2021
GiteaBot
added
the
lgtm/need 2
|
if you need help for the fixtures (witch are broken right now) just ask |
|
@6543 HELP! :D |
6543
approved these changes
Mar 13, 2021
GiteaBot
added
lgtm/need 1
zeripath
approved these changes
Mar 13, 2021
GiteaBot
added
lgtm/done
|
@noerw please backport |
noerw
added a commit
to noerw/gitea
that referenced
this pull request
Mar 15, 2021
* API: fix set milestone on PR creation pr creation via API failed with 404, because we searched for milestoneID 0, due to uninitialized var usage D: * add tests Co-authored-by: 6543 <6543@obermui.de>
techknowlogick
pushed a commit
that referenced
this pull request
Mar 15, 2021
* API: fix set milestone on PR creation pr creation via API failed with 404, because we searched for milestoneID 0, due to uninitialized var usage D: * add tests Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: 6543 <6543@obermui.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR creation via API failed with 404, because we searched
for milestoneID 0, due to uninitialized var usage D: (isn't this what linters are for?)