Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: fix set milestone on PR creation (#14981) #15001

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

noerw
Copy link
Member

@noerw noerw commented Mar 15, 2021

backport of #14981

  • API: fix set milestone on PR creation

    pr creation via API failed with 404, because we searched
    for milestoneID 0, due to uninitialized var usage D:

  • add tests

Co-authored-by: 6543 6543@obermui.de

* API: fix set milestone on PR creation

pr creation via API failed with 404, because we searched
for milestoneID 0, due to uninitialized var usage D:

* add tests

Co-authored-by: 6543 <6543@obermui.de>
@noerw noerw added the type/bug label Mar 15, 2021
@noerw noerw added this to the 1.13.5 milestone Mar 15, 2021
@noerw noerw added the modifies/api This PR adds API routes or modifies them label Mar 15, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 15, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 15, 2021
@techknowlogick techknowlogick merged commit fff66eb into go-gitea:release/v1.13 Mar 15, 2021
@6543 6543 deleted the backport-14981 branch March 15, 2021 22:49
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants