Exponential Backoff for ByteFIFO #15724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is another in the vein of queue improvements. It suggests an exponential backoff for bytefifo queues to reduce the load from queue polling. This will mostly be useful for redis queues. Signed-off-by: Andrew Thornton <art27@cantab.net>
|
Related #15542 |
GiteaBot
added
the
lgtm/need 2
|
This could easily be moved in to #15693 |
silverwind
approved these changes
May 6, 2021
GiteaBot
added
lgtm/need 1
6543
approved these changes
May 7, 2021
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #15724 +/- ##
==========================================
+ Coverage 43.96% 43.98% +0.01%
==========================================
Files 678 678
Lines 81998 82016 +18
==========================================
+ Hits 36053 36074 +21
+ Misses 40072 40069 -3
Partials 5873 5873
Continue to review full report at Codecov.
|
lafriks
reviewed
May 8, 2021
lafriks
previously requested changes
May 8, 2021
Co-authored-by: Lauris BH <lauris@nix.lv>
lunny
reviewed
May 8, 2021
lafriks
approved these changes
May 8, 2021
Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
May 8, 2021
This PR is another in the vein of queue improvements. It suggests an exponential backoff for bytefifo queues to reduce the load from queue polling. This will mostly be useful for redis queues. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv>
|
-> #15793 |
techknowlogick
pushed a commit
that referenced
this pull request
May 8, 2021
This PR is another in the vein of queue improvements. It suggests an exponential backoff for bytefifo queues to reduce the load from queue polling. This will mostly be useful for redis queues. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv>
12 tasks
7 tasks
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
This PR is another in the vein of queue improvements. It suggests an exponential backoff for bytefifo queues to reduce the load from queue polling. This will mostly be useful for redis queues. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lauris BH <lauris@nix.lv>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another in the vein of queue improvements. It suggests an
exponential backoff for bytefifo queues to reduce the load from queue
polling. This will mostly be useful for redis queues.
Related #15542
Signed-off-by: Andrew Thornton art27@cantab.net