Fix bug in reverse proxy #16026
Merged
Fix bug in reverse proxy #16026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeripath
added
type/bug
skip-changelog
zeripath
force-pushed
the
fix-16025-super-check-against-nil
branch
from
f7ffa15 to
9e3904a
Compare
Codecov Report
@@ Coverage Diff @@
## main #16026 +/- ##
==========================================
- Coverage 44.10% 44.08% -0.02%
==========================================
Files 682 682
Lines 82375 82375
==========================================
- Hits 36328 36313 -15
- Misses 40140 40153 +13
- Partials 5907 5909 +2
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lunny
reviewed
May 30, 2021
Unfortunately go panics you try to cast a nil interface{} as another primitive
therefore you need to check interfaces are not nil before casting.
Fix go-gitea#16025
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
fix-16025-super-check-against-nil
branch
from
9e3904a to
89dd44e
Compare
techknowlogick
approved these changes
May 30, 2021
GiteaBot
added
lgtm/need 1
adelowo
approved these changes
May 31, 2021
GiteaBot
added
lgtm/done
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
Unfortunately go panics you try to cast a nil interface{} as another primitive
therefore you need to check interfaces are not nil before casting.
Fix go-gitea#16025
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately go panics you try to cast a nil interface{} as another primitive
therefore you need to check interfaces are not nil before casting.
Regression from #15304
Fix #16025
Signed-off-by: Andrew Thornton art27@cantab.net