Set HeadCommit when creating tags #18116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well, that should be a enhancement for another PR as it's in this case a valid URL in that sense. |
GiteaBot
added
the
lgtm/need 2
Gusted
approved these changes
Dec 28, 2021
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Dec 29, 2021
wxiaoguang
approved these changes
Dec 29, 2021
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #18116 +/- ##
=======================================
Coverage ? 44.91%
=======================================
Files ? 824
Lines ? 91598
Branches ? 0
=======================================
Hits ? 41144
Misses ? 43859
Partials ? 6595
Continue to review full report at Codecov.
|
|
I think it's better to backport this to v1.15 |
zjjhot
pushed a commit
to zjjhot/gitea
that referenced
this pull request
Dec 29, 2021
* giteaoffical/main: Use conditions but not repo ids as query condition (go-gitea#16839) Set HeadCommit when creating tags. (go-gitea#18116)
|
Please send backport. |
lunny
pushed a commit
to lunny/gitea
that referenced
this pull request
Jan 4, 2022
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
6543
pushed a commit
that referenced
this pull request
Jan 4, 2022
Merged
zeripath
pushed a commit
that referenced
this pull request
Jan 14, 2022
[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14 * BUGFIXES * Fix inconsistent PR comment counts (#18260) (#18261) * Fix release link broken (#18252) (#18253) * Fix update user from site administration page bug (#18250) (#18251) * Set HeadCommit when creating tags (#18116) (#18173) * Use correct translation key for error messages due to max repo limits (#18135 & #18153) (#18152) * Fix purple color in suggested label colors (#18241) (#18242) * SECURITY * Bump mermaid from 8.10.1 to 8.13.8 (#18198) (#18206)
zeripath
pushed a commit
to zeripath/gitea
that referenced
this pull request
Jan 14, 2022
[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14 * BUGFIXES * Fix inconsistent PR comment counts (go-gitea#18260) (go-gitea#18261) * Fix release link broken (go-gitea#18252) (go-gitea#18253) * Fix update user from site administration page bug (go-gitea#18250) (go-gitea#18251) * Set HeadCommit when creating tags (go-gitea#18116) (go-gitea#18173) * Use correct translation key for error messages due to max repo limits (go-gitea#18135 & go-gitea#18153) (go-gitea#18152) * Fix purple color in suggested label colors (go-gitea#18241) (go-gitea#18242) * SECURITY * Bump mermaid from 8.10.1 to 8.13.8 (go-gitea#18198) (go-gitea#18206)
techknowlogick
pushed a commit
that referenced
this pull request
Jan 14, 2022
* Changelog for 1.15.10 (#18274) [1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14 * BUGFIXES * Fix inconsistent PR comment counts (#18260) (#18261) * Fix release link broken (#18252) (#18253) * Fix update user from site administration page bug (#18250) (#18251) * Set HeadCommit when creating tags (#18116) (#18173) * Use correct translation key for error messages due to max repo limits (#18135 & #18153) (#18152) * Fix purple color in suggested label colors (#18241) (#18242) * SECURITY * Bump mermaid from 8.10.1 to 8.13.8 (#18198) (#18206) * update docs/config.yaml Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Richard Mahn <richmahn@users.noreply.github.com>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* Changelog for 1.15.10 (go-gitea#18274) [1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14 * BUGFIXES * Fix inconsistent PR comment counts (go-gitea#18260) (go-gitea#18261) * Fix release link broken (go-gitea#18252) (go-gitea#18253) * Fix update user from site administration page bug (go-gitea#18250) (go-gitea#18251) * Set HeadCommit when creating tags (go-gitea#18116) (go-gitea#18173) * Use correct translation key for error messages due to max repo limits (go-gitea#18135 & go-gitea#18153) (go-gitea#18152) * Fix purple color in suggested label colors (go-gitea#18241) (go-gitea#18242) * SECURITY * Bump mermaid from 8.10.1 to 8.13.8 (go-gitea#18198) (go-gitea#18206) * update docs/config.yaml Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Richard Mahn <richmahn@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18112
It's the same behaviour as if you create a branch: empty commit list but the head commit is the last commit.
I'm not sure about the compare url. With
git.EmptySHAyou will see a 404 page. GitHub displays a "There isn’t anything to compare" page in this case.