-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct translation key for max repo limit error messages #18135
Conversation
Gusted
commented
Dec 30, 2021
•
edited by zeripath
Loading
edited by zeripath
- Resolves Error message broken when migrating repo at max repo limit #18122
- Resolves go-gitea#18122
Could we refactor the function gitea/modules/templates/helper.go Line 898 in a3d6850
IMO we should have a unified behavior in both template and backend code. ps: the old |
Codecov Report
@@ Coverage Diff @@
## main #18135 +/- ##
==========================================
- Coverage 44.95% 44.94% -0.01%
==========================================
Files 825 825
Lines 91559 91575 +16
==========================================
- Hits 41159 41158 -1
- Misses 43818 43837 +19
+ Partials 6582 6580 -2
Continue to review full report at Codecov.
|
That could be another PR. |
Please send backport. |
I proposed a refactoring for |
* giteaoffical/main: tests: s/GITEA_UNIT_TESTS_VERBOSE/GITEA_UNIT_TESTS_LOG_SQL/ (go-gitea#18142) services/repository: fix ListUnadoptedRepositories incorrect total count (go-gitea#17865) Improve document for developers: Windows CGO, unit test option (go-gitea#18140) Reset the conflicted files list in testpatch (go-gitea#18139) Use correct translation key (go-gitea#18135)
- Backport of go-gitea#18135
Refer: #18135 (comment) Now we have a unique and simple `TrN`, and make the fix of PR #18135 also use the better `TrN` logic.
[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14 * BUGFIXES * Fix inconsistent PR comment counts (#18260) (#18261) * Fix release link broken (#18252) (#18253) * Fix update user from site administration page bug (#18250) (#18251) * Set HeadCommit when creating tags (#18116) (#18173) * Use correct translation key for error messages due to max repo limits (#18135 & #18153) (#18152) * Fix purple color in suggested label colors (#18241) (#18242) * SECURITY * Bump mermaid from 8.10.1 to 8.13.8 (#18198) (#18206)
[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14 * BUGFIXES * Fix inconsistent PR comment counts (go-gitea#18260) (go-gitea#18261) * Fix release link broken (go-gitea#18252) (go-gitea#18253) * Fix update user from site administration page bug (go-gitea#18250) (go-gitea#18251) * Set HeadCommit when creating tags (go-gitea#18116) (go-gitea#18173) * Use correct translation key for error messages due to max repo limits (go-gitea#18135 & go-gitea#18153) (go-gitea#18152) * Fix purple color in suggested label colors (go-gitea#18241) (go-gitea#18242) * SECURITY * Bump mermaid from 8.10.1 to 8.13.8 (go-gitea#18198) (go-gitea#18206)
* Changelog for 1.15.10 (#18274) [1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14 * BUGFIXES * Fix inconsistent PR comment counts (#18260) (#18261) * Fix release link broken (#18252) (#18253) * Fix update user from site administration page bug (#18250) (#18251) * Set HeadCommit when creating tags (#18116) (#18173) * Use correct translation key for error messages due to max repo limits (#18135 & #18153) (#18152) * Fix purple color in suggested label colors (#18241) (#18242) * SECURITY * Bump mermaid from 8.10.1 to 8.13.8 (#18198) (#18206) * update docs/config.yaml Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Richard Mahn <richmahn@users.noreply.github.com>
- Resolves go-gitea#18122 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Refer: go-gitea#18135 (comment) Now we have a unique and simple `TrN`, and make the fix of PR go-gitea#18135 also use the better `TrN` logic.
* Changelog for 1.15.10 (go-gitea#18274) [1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14 * BUGFIXES * Fix inconsistent PR comment counts (go-gitea#18260) (go-gitea#18261) * Fix release link broken (go-gitea#18252) (go-gitea#18253) * Fix update user from site administration page bug (go-gitea#18250) (go-gitea#18251) * Set HeadCommit when creating tags (go-gitea#18116) (go-gitea#18173) * Use correct translation key for error messages due to max repo limits (go-gitea#18135 & go-gitea#18153) (go-gitea#18152) * Fix purple color in suggested label colors (go-gitea#18241) (go-gitea#18242) * SECURITY * Bump mermaid from 8.10.1 to 8.13.8 (go-gitea#18198) (go-gitea#18206) * update docs/config.yaml Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Richard Mahn <richmahn@users.noreply.github.com>