Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve document for developers: Windows CGO, unit test option #18140

Merged
merged 3 commits into from
Dec 31, 2021
Merged

Improve document for developers: Windows CGO, unit test option #18140

merged 3 commits into from
Dec 31, 2021

Conversation

wxiaoguang
Copy link
Contributor

  1. Clarify how to compile Gitea on Windows with CGO_ENABLED
  2. Document a useful environment variable GITEA_UNIT_TESTS_VERBOSE

@codecov-commenter

This comment has been minimized.

Sign in to view
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 31, 2021
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Dec 31, 2021
lunny
lunny approved these changes Dec 31, 2021
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 31, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 31, 2021
@wxiaoguang wxiaoguang merged commit c99b8ef into go-gitea:main Dec 31, 2021
@wxiaoguang wxiaoguang deleted the fix-dev-doc branch December 31, 2021 14:21
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 1, 2022
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
739d84c 
* giteaoffical/main:
  tests: s/GITEA_UNIT_TESTS_VERBOSE/GITEA_UNIT_TESTS_LOG_SQL/ (go-gitea#18142)
  services/repository: fix ListUnadoptedRepositories incorrect total count (go-gitea#17865)
  Improve document for developers: Windows CGO, unit test option (go-gitea#18140)
  Reset the conflicted files list in testpatch (go-gitea#18139)
  Use correct translation key (go-gitea#18135)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@wxiaoguang
Improve document for developers: Windows CGO, unit test option (go-gi…
d9bf574 
…tea#18140)
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @codecov-commenter @lunny @6543 @GiteaBot