Refactor legacy git init #20376
Merged
Refactor legacy git init #20376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
added
the
type/refactoring
|
@zeripath This PR follows your suggestion:
|
GiteaBot
added
the
lgtm/need 2
zeripath
reviewed
Jul 23, 2022
Co-authored-by: zeripath <art27@cantab.net>
lunny
approved these changes
Aug 7, 2022
GiteaBot
added
lgtm/need 1
delvh
reviewed
Aug 7, 2022
delvh
approved these changes
Aug 8, 2022
GiteaBot
added
lgtm/done
|
make L-G-T-M work |
|
@zeripath I would suppose that there is no more change from your side. I will merge this one. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 9, 2022
* giteaofficial/main: Add support for `npm unpublish` (go-gitea#20688) Allow multiple files in generic packages (go-gitea#20661) Refactor legacy git init (go-gitea#20376) Fix typo in source (go-gitea#20723) [skip ci] Updated translations via Crowdin Add issue filter for Author (go-gitea#20578) Fix init mail render logic (go-gitea#20704) Frontport changelog v1.17.0 (go-gitea#20712) Fix disable download button (go-gitea#20701) docs: move search input to navbar (go-gitea#20551) Fix SecToTime edge-cases (go-gitea#20610)
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
* merge `CheckLFSVersion` into `InitFull` (renamed from `InitWithSyncOnce`) * remove the `Once` during git init, no data-race now * for doctor sub-commands, `InitFull` should only be called in initialization stage Co-authored-by: zeripath <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This was referenced Aug 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows:
Major changes:
CheckLFSVersionintoInitFull(renamed fromInitWithSyncOnce)Onceduring git init, no data-race now (although some global variables like globalCommandArgs should be eliminated, it could be done in the future)InitFullshould only be called in initialization stageAnd some more hints: a behavior is changed after this PR for Git < 2.1.2 when LFS.StartServer=true:
Although it is a breaking change, it's very trivial, because Git 2.1.x is quite old (8 years ago. https://github.com/git/git/blob/master/Documentation/RelNotes/). I would assume that few people are still using it, and they should know how to handle the version problem according to the error prompt if they are upgrading Gitea to 1.18.
So, IMO it's not worth to mention such trivial breaking in changelog.