Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move search input to navbar #20551

Merged
merged 4 commits into from
Aug 8, 2022
Merged

Conversation

noerw
Copy link
Member

@noerw noerw commented Jul 30, 2022

Previously, the search input was on a dedicated search page, being rather unwieldy.

small medium large
Screenshot_20220730_140343 Screenshot_20220730_140330 Screenshot_20220730_140322

@noerw noerw added type/docs This PR mainly updates/creates documentation kind/usability labels Jul 30, 2022
@noerw

This comment was marked as outdated.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 30, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 31, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 1, 2022
@silverwind
Copy link
Member

silverwind commented Aug 2, 2022

Not a problem with this PR, but the input text is off-center vertically. Likely has something to do with the percentage height (generally percentages should be avoided in CSS):

image

@noerw
Copy link
Member Author

noerw commented Aug 2, 2022

@silverwind I don't know how to fix that. I have spent hours (days?) in the past trying to vertically align inputs across browsers and have given up at this point. If you know how to fix that I'd be happy to learn 🙃
(Either way, that's to be fixed in the theme repo, not here)

@Gusted
Copy link
Contributor

Gusted commented Aug 2, 2022

image

Looks fine on my machine :P

@wxiaoguang
Copy link
Contributor

It seems no more suggestions since 6 days ago. Ready to merge

@wxiaoguang wxiaoguang merged commit 68059ab into go-gitea:main Aug 8, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 9, 2022
* giteaofficial/main:
  Add support for `npm unpublish` (go-gitea#20688)
  Allow multiple files in generic packages (go-gitea#20661)
  Refactor legacy git init (go-gitea#20376)
  Fix typo in source (go-gitea#20723)
  [skip ci] Updated translations via Crowdin
  Add issue filter for Author (go-gitea#20578)
  Fix init mail render logic (go-gitea#20704)
  Frontport changelog v1.17.0 (go-gitea#20712)
  Fix disable download button (go-gitea#20701)
  docs: move search input to navbar (go-gitea#20551)
  Fix SecToTime edge-cases (go-gitea#20610)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
* remove search item from sidebar
* fix search for some docs languages

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@delvh delvh added topic/ui-interaction Change the process how users use Gitea instead of the visual appearance and removed kind/usability labels Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui-interaction Change the process how users use Gitea instead of the visual appearance type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants