Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag list should include draft releases with existing tags #21263

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Tag list should include draft releases with existing tags #21263

merged 4 commits into from
Oct 3, 2022

Conversation

wolfogre
Copy link
Member

@wolfogre wolfogre commented Sep 26, 2022

Fix #21262.

A patch for #15137.

The draft releases which are created with existing tags should be included in the tag list.

image

image

@wolfogre wolfogre changed the title Include draft releases in the tag list Tag list should include draft releases with existing tags Sep 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #21263 (8e51fbc) into main (ec0a06e) will increase coverage by 47.11%.
The diff coverage is 76.92%.

@@            Coverage Diff            @@
##           main   #21263       +/-   ##
=========================================
+ Coverage      0   47.11%   +47.11%     
=========================================
  Files         0     1017     +1017     
  Lines         0   138129   +138129     
=========================================
+ Hits          0    65075    +65075     
- Misses        0    65103    +65103     
- Partials      0     7951     +7951     
Impacted Files Coverage Δ
models/repo/release.go 45.35% <50.00%> (ø)
modules/context/repo.go 53.72% <100.00%> (ø)
routers/web/repo/release.go 27.69% <100.00%> (ø)
routers/api/v1/repo/notes.go 82.14% <0.00%> (ø)
models/asymkey/ssh_key_authorized_keys.go 16.15% <0.00%> (ø)
modules/git/batch_reader.go 55.88% <0.00%> (ø)
modules/packages/container/metadata.go 76.92% <0.00%> (ø)
modules/util/string.go 89.65% <0.00%> (ø)
modules/base/natural_sort.go 93.65% <0.00%> (ø)
models/repo/wiki.go 44.44% <0.00%> (ø)
... and 1010 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 26, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 28, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 3, 2022
@wxiaoguang wxiaoguang merged commit a08b484 into go-gitea:main Oct 3, 2022
@wxiaoguang wxiaoguang added this to the 1.18.0 milestone Oct 7, 2022
@wxiaoguang
Copy link
Contributor

please send a backport ~

@wxiaoguang wxiaoguang added the backport/done All backports for this PR have been created label Oct 7, 2022
wxiaoguang added a commit that referenced this pull request Oct 7, 2022
…21365)

Backport #21263.

Before, a tag for a draft release disappeared in the tag list, fix #21262.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
tyroneyeh added a commit to tyroneyeh/gitea that referenced this pull request Oct 24, 2022
…1263) (go-gitea#21365)

Backport go-gitea#21263.

Before, a tag for a draft release disappeared in the tag list, fix go-gitea#21262.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The tag will disappear if a draft release has been created with it
5 participants