Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce eslint-plugin-no-jquery/no-event-shorthand #24198

Merged
merged 6 commits into from
Apr 20, 2023
Merged

Introduce eslint-plugin-no-jquery/no-event-shorthand #24198

merged 6 commits into from
Apr 20, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Apr 19, 2023

@yp05327 yp05327 mentioned this pull request Apr 19, 2023
Closed
silverwind
silverwind reviewed Apr 19, 2023
View reviewed changes
.eslintrc.yaml Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 19, 2023
@yp05327 @silverwind
Update .eslintrc.yaml
9aec16b 
Co-authored-by: silverwind <me@silverwind.io>
@silverwind
Copy link
Member

15 errors found now, try with --fix.

@techknowlogick techknowlogick added this to the 1.20.0 milestone Apr 20, 2023
@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 20, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 20, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Apr 20, 2023

@silverwind
Thanks for your kindness help. 😄

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 20, 2023
@silverwind
Copy link
Member

No problem. I think I will explore enabling more rules from that plugin. Those that do have autofix available are a breeze to integrate, like this rule.

@silverwind silverwind enabled auto-merge (squash) April 20, 2023 08:33
@silverwind silverwind merged commit 8ea33ba into go-gitea:main Apr 20, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 20, 2023
@yp05327 yp05327 deleted the add-no-jquery-no-event-shorthand branch April 21, 2023 06:29
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 21, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a4c41bb 
* giteaofficial/main:
  Fix label color, fix divider in dropdown (go-gitea#24215)
  [skip ci] Updated translations via Crowdin
  Refactor web route (go-gitea#24080)
  Fix unclear "Owner" concept (go-gitea#24233)
  Introduce eslint-plugin-no-jquery/no-event-shorthand (go-gitea#24198)
  Use secondary pointing menu for tabs on user/organization home page (go-gitea#24162)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
7 participants
@yp05327 @silverwind @lunny @yardenshoham @delvh @techknowlogick @GiteaBot