Fix unclear "Owner" concept #24233
Merged
Fix unclear "Owner" concept #24233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
added
type/enhancement
silverwind
approved these changes
Apr 20, 2023
GiteaBot
added
the
lgtm/need 1
6543
approved these changes
Apr 20, 2023
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 21, 2023
* giteaofficial/main: Fix label color, fix divider in dropdown (go-gitea#24215) [skip ci] Updated translations via Crowdin Refactor web route (go-gitea#24080) Fix unclear "Owner" concept (go-gitea#24233) Introduce eslint-plugin-no-jquery/no-event-shorthand (go-gitea#24198) Use secondary pointing menu for tabs on user/organization home page (go-gitea#24162)
wxiaoguang
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #24232
Some user/org pages use
Ownervariable. It's an incorrect concept since year 2016: what is a user's owner?Actually, new code is right: use
ContextUser.This PR cleans all legacy "Owner" variables.
Screenshots for related pages and test results
All pages are as before:
web/org/home.goweb/user/profile.goweb/user/setting/profile.go