Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions cleanups #24620

Merged
merged 15 commits into from
May 12, 2023
Merged

GitHub Actions cleanups #24620

merged 15 commits into from
May 12, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented May 9, 2023 •
edited
Loading

  • Remove actions name where command is descriptive enough
  • Use kebab-case instead of snake-case for step names
  • Use shorter job names because to make PR checks more readable
  • Remove duplicate checks-backend

@silverwind
Actions cleanups
5af3efd 
- Remove actions name where command is descriptive enough
- Use kebab-case instead of snake-case for step names
- Use shorter job names because to make PR checks more readable
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 9, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 9, 2023
@silverwind silverwind added type/testing topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 9, 2023
@silverwind
Copy link
Member Author

silverwind commented May 9, 2023 •
edited
Loading

Could maybe even go shorter and lowercase for workflow name, so

Database Tests / test-pgsql (pull_request)

could become

db / test-pgsql (pull_request)

@silverwind silverwind changed the title Actions cleanups GitHub Actions cleanups May 9, 2023
techknowlogick
techknowlogick reviewed May 10, 2023
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning things up. I've made a few notes, mainly about things that I have second thoughts about if I should've changed for my original PR, but none of the comments are blockers for me.

.github/workflows/pull-compliance.yml Outdated Show resolved Hide resolved
.github/workflows/lock.yml Outdated Show resolved Hide resolved
.github/workflows/cron-licenses.yml Outdated Show resolved Hide resolved
.github/workflows/pull-db_test.yml Outdated Show resolved Hide resolved
@silverwind
Copy link
Member Author

One TODO: lint-editoconfig runs twice: https://github.com/go-gitea/gitea/actions/runs/4933067739/jobs/8816691047?pr=24526

@silverwind silverwind marked this pull request as draft May 10, 2023 15:39
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 11, 2023
@silverwind silverwind marked this pull request as ready for review May 11, 2023 17:44
@silverwind
Copy link
Member Author

All resolved, so should be ready.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 11, 2023
@techknowlogick
Copy link
Member

Thanks <3

@silverwind
Copy link
Member Author

Might have to admin-merge this because it shows the old workflow names in the checks list, forever "waiting".

@techknowlogick
Copy link
Member

Might have to admin-merge this because it shows the old workflow names in the checks list, forever "waiting".

yup, once this gets a second +1 then I'll (or another TOC member) adjust branch protection rules for the new names :)

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 11, 2023
@silverwind
Copy link
Member Author

Restored the pull-* scheme in the filenames again, it was an experiment from earlier :)

yardenshoham
yardenshoham reviewed May 11, 2023
View reviewed changes
Copy link
Member

@yardenshoham yardenshoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way cleaner, I like this

.github/workflows/pull-docker-dryrun.yml Outdated Show resolved Hide resolved
.github/workflows/pull-e2e-tests.yml Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 11, 2023
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 11, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) May 12, 2023 01:17
@techknowlogick techknowlogick merged commit 6c8b680 into go-gitea:main May 12, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone May 12, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 12, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 12, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
39754d7 
* upstream/main:
  GitHub Actions cleanups (go-gitea#24620)
  Fix issues list page multiple selection update milestones (go-gitea#24660)
  Make repo migration cancelable and fix various bugs (go-gitea#24605)
  Improve queue & process & stacktrace (go-gitea#24636)
  Fix missing badges in org settings page (go-gitea#24654)
  Only show one tippy at a time (go-gitea#24648)
  Reenable creating default webhooks. (go-gitea#24626)
  Kd/fix redis unit test (go-gitea#24650)
@silverwind silverwind deleted the actions-cleanup branch May 12, 2023 07:04
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/testing
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @techknowlogick @lunny @yardenshoham @GiteaBot