Kd/fix redis unit test #24650
Merged
Kd/fix redis unit test #24650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
kdumontnu
force-pushed
the
kd/fix-redis_unit_test
branch
from
a22af97
to
5acb76a
Compare
kdumontnu
force-pushed
the
kd/fix-redis_unit_test
branch
from
5acb76a
to
f9cbc8f
Compare
silverwind
approved these changes
May 11, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
May 11, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
|
Thank you. That's what I planned to do but haven't done yet 😁 I think in the future we can use redis to test more code, eg: cache? session? |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 12, 2023
* upstream/main: GitHub Actions cleanups (go-gitea#24620) Fix issues list page multiple selection update milestones (go-gitea#24660) Make repo migration cancelable and fix various bugs (go-gitea#24605) Improve queue & process & stacktrace (go-gitea#24636) Fix missing badges in org settings page (go-gitea#24654) Only show one tippy at a time (go-gitea#24648) Reenable creating default webhooks. (go-gitea#24626) Kd/fix redis unit test (go-gitea#24650)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #24641
Currently, unit tests fail when run locally (unless users have minio instance running). This PR only requires redis unit tests if in CI.
CIenv variable is set