Create pull request for base after editing file, if not enabled on fork #24841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for fork Currently if pull requests are disabled on a fork but enabled on a base repo, creating/editing/deleting files does not offer the option to create a pull request. This change enables creating a pull request in that case.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
|
What I'm really trying to solve is users accidentally creating PRs for their own fork, which is rarely what's needed in our workflow and quite confusing to them. Combined with disabling the pull requests unit on forked repositories by default, this accomplishes that for us. It could be argued that creating a PR for the base repository should be default also when pull requests are enabled for the fork. That would suit me, but it would be a change to existing behavior and would be different than what GitHub does. |
silverwind
approved these changes
May 22, 2023
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
May 24, 2023
wxiaoguang
reviewed
May 24, 2023
wxiaoguang
approved these changes
May 24, 2023
GiteaBot
added
lgtm/done
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 25, 2023
* upstream/main: (21 commits) `zh-cn` translation for usage docs (go-gitea#24897) Add chinese documentations for installation (go-gitea#24904) Improve RunMode / dev mode (go-gitea#24886) Add chinese documentations for `Packages` (go-gitea#24914) Rework notifications list (go-gitea#24812) New webhook trigger for receiving Pull Request review requests (go-gitea#24481) Use file filters action instead of Github's files filter (go-gitea#24877) Update Asciidoc markup example with safe defaults (go-gitea#24920) Add self to maintainers (go-gitea#23644) Create pull request for base after editing file, if not enabled on fork (go-gitea#24841) Reduce verbosity of dev commands (go-gitea#24917) Merge different languages for language stats (go-gitea#24900) Add missing test case and fix typo in tests (go-gitea#24915) Improve confusable character string (go-gitea#24911) Improve Actions CSS (go-gitea#24864) Fix <empty> in administration/config-cheat-sheet.en-us.md (go-gitea#24905) Only validate changed columns when update user (go-gitea#24867) Rename docs packages title from xxx Packages Repository -> xxx Package Registry (go-gitea#24895) Fix can’t move anymore items in repo project boards (go-gitea#24892) Make environment-to-ini support loading key value from file (go-gitea#24832) ... # Conflicts: # web_src/css/helpers.css
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if pull requests are disabled on a fork but enabled on a base repo, creating/editing/deleting files does not offer the option to create a pull request. This change enables creating a pull request for the base repo in that case.