Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use file filters action instead of Github's files filter #24877

Merged
merged 12 commits into from
May 25, 2023
Merged

Use file filters action instead of Github's files filter #24877

merged 12 commits into from
May 25, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented May 23, 2023 •
edited
Loading

Inspired by #24530 (comment)

This PR use a file filter action to do different CI jobs according changed files types. All types are defined in .github/file-filters.yml. Now there are 4 types, docs, backend, frontend and build. Then if a PR only changed docs files, those CI jobs which passed the conditions will run, and other types are also like this.

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label May 23, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 23, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 23, 2023
@lunny lunny requested review from silverwind and techknowlogick and removed request for silverwind May 23, 2023 09:59
@lunny lunny mentioned this pull request May 23, 2023
Closed
@silverwind silverwind mentioned this pull request May 23, 2023
Closed
@silverwind
Copy link
Member

silverwind commented May 23, 2023 •
edited
Loading

👍 from me, it'll save a lot of CI time via the backend/frontend/docs split. Not sure what to do about E2E tests, they likely need to always run still.

@lunny lunny marked this pull request as ready for review May 24, 2023 07:50
@lunny
Copy link
Member Author

lunny commented May 24, 2023

It's ready to review now.

silverwind
silverwind reviewed May 24, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
silverwind
silverwind reviewed May 24, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
silverwind
silverwind reviewed May 24, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
silverwind
silverwind reviewed May 24, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
silverwind
silverwind reviewed May 24, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@lunny @silverwind
Apply suggestions from code review
750e459 
Co-authored-by: silverwind <me@silverwind.io>
silverwind
silverwind approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it. For actionlint, we could add another filter category, btw.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 24, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 25, 2023
@techknowlogick techknowlogick added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 25, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) May 25, 2023 01:32
@techknowlogick techknowlogick merged commit 93c6a9a into go-gitea:main May 25, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone May 25, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 25, 2023
@lunny lunny deleted the lunny/fix_docs_build branch May 25, 2023 01:36
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 25, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
0f56349 
* upstream/main: (21 commits)
  `zh-cn` translation for usage docs (go-gitea#24897)
  Add chinese documentations for installation (go-gitea#24904)
  Improve RunMode / dev mode (go-gitea#24886)
  Add chinese documentations for `Packages` (go-gitea#24914)
  Rework notifications list (go-gitea#24812)
  New webhook trigger for receiving Pull Request review requests (go-gitea#24481)
  Use file filters action instead of Github's files filter (go-gitea#24877)
  Update Asciidoc markup example with safe defaults (go-gitea#24920)
  Add self to maintainers (go-gitea#23644)
  Create pull request for base after editing file, if not enabled on fork (go-gitea#24841)
  Reduce verbosity of dev commands (go-gitea#24917)
  Merge different languages for language stats (go-gitea#24900)
  Add missing test case and fix typo in tests (go-gitea#24915)
  Improve confusable character string (go-gitea#24911)
  Improve Actions CSS (go-gitea#24864)
  Fix <empty> in administration/config-cheat-sheet.en-us.md (go-gitea#24905)
  Only validate changed columns when update user (go-gitea#24867)
  Rename docs packages title from xxx Packages Repository -> xxx Package Registry (go-gitea#24895)
  Fix can’t move anymore items in repo project boards (go-gitea#24892)
  Make environment-to-ini  support loading key value from file (go-gitea#24832)
  ...

# Conflicts:
#	web_src/css/helpers.css
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @silverwind @techknowlogick @GiteaBot