Fix PR creation via api between branches of same repo with head field namespaced #26986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
lunny
reviewed
Sep 11, 2023
|
Sorry for the ping/bump, having automated PR creation in various projects (release, deployment, dependency, syntax,...) it would be nice seeing it resolved. |
lunny
approved these changes
Nov 19, 2023
GiteaBot
added
lgtm/need 1
|
last call for this one. @go-gitea/technical-oversight-committee |
wolfogre
approved these changes
Mar 15, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
|
Tests are failing |
yardenshoham
removed
the
reviewed/wait-merge
auto-merge was automatically disabled
March 16, 2024 14:42
Head branch was pushed to by a user without write access
yardenshoham
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 17, 2024
… namespaced (go-gitea#26986) Fix go-gitea#20175 Current implementation of API does not allow creating pull requests between branches of the same repo when you specify *namespace* (owner of the repo) in `head` field in http request body. --- Although GitHub implementation of API allows performing such action and since Gitea targeting compatibility with GitHub API I see it as an appropriate change. I'm proposing a fix to the described problem and test case which covers this logic. My use-case just in case: go-gitea#20175 (comment)
GiteaBot
added
backport/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 17, 2024
* giteaofficial/main: Fix PR creation via api between branches of same repo with head field namespaced (go-gitea#26986) Remove fomantic message module (go-gitea#29856) fix double border and border-radius on empty action steps (go-gitea#29845) add `.suppressed` link class (go-gitea#29847)
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Mar 17, 2024
… namespaced (go-gitea#26986) Fix go-gitea#20175 Current implementation of API does not allow creating pull requests between branches of the same repo when you specify *namespace* (owner of the repo) in `head` field in http request body. --- Although GitHub implementation of API allows performing such action and since Gitea targeting compatibility with GitHub API I see it as an appropriate change. I'm proposing a fix to the described problem and test case which covers this logic. My use-case just in case: go-gitea#20175 (comment)
lunny
added a commit
that referenced
this pull request
Mar 20, 2024
… namespaced (#26986) (#29857) Backport #26986 by @norohind Fix #20175 Current implementation of API does not allow creating pull requests between branches of the same repo when you specify *namespace* (owner of the repo) in `head` field in http request body. --------- Co-authored-by: norohind <60548839+norohind@users.noreply.github.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20175
Current implementation of API does not allow creating pull requests between branches of the same
repo when you specify namespace (owner of the repo) in
headfield in http request body.Although GitHub implementation of API allows performing such action and since Gitea targeting
compatibility with GitHub API I see it as an appropriate change.
I'm proposing a fix to the described problem and test case which covers this logic.
My use-case just in case: #20175 (comment)