Fix PR creation via api between branches of same repo with head field namespaced (#26986) #29857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… namespaced (go-gitea#26986) Fix go-gitea#20175 Current implementation of API does not allow creating pull requests between branches of the same repo when you specify *namespace* (owner of the repo) in `head` field in http request body. --- Although GitHub implementation of API allows performing such action and since Gitea targeting compatibility with GitHub API I see it as an appropriate change. I'm proposing a fix to the described problem and test case which covers this logic. My use-case just in case: go-gitea#20175 (comment)
GiteaBot
added
modifies/api
pull-request-size
bot
added
the
size/S
lunny
approved these changes
Mar 17, 2024
GiteaBot
added
lgtm/need 1
denyskon
suggested changes
Mar 17, 2024
GiteaBot
added
lgtm/blocked
|
I think it's because in 1.21 (where my PR is being backported, as far as I understand) there is no support |
lunny
approved these changes
Mar 18, 2024
lunny
approved these changes
Mar 18, 2024
lunny
removed
the
lgtm/blocked
GiteaBot
added
the
lgtm/blocked
denyskon
approved these changes
Mar 19, 2024
GiteaBot
added
lgtm/done
denyskon
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #26986 by @norohind
Fix #20175
Current implementation of API does not allow creating pull requests between branches of the same
repo when you specify namespace (owner of the repo) in
headfield in http request body.Although GitHub implementation of API allows performing such action and since Gitea targeting
compatibility with GitHub API I see it as an appropriate change.
I'm proposing a fix to the described problem and test case which covers this logic.
My use-case just in case: #20175 (comment)