-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final round of db.DefaultContext
refactor
#27587
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Oct 11, 2023
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Oct 11, 2023
github-actions
bot
added
modifies/api
This PR adds API routes or modifies them
modifies/cli
PR changes something on the CLI, i.e. gitea doctor or gitea admin
labels
Oct 11, 2023
KN4CK3R
reviewed
Oct 12, 2023
delvh
added
the
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
label
Oct 12, 2023
delvh
approved these changes
Oct 12, 2023
@@ -40,7 +40,7 @@ func LFSPush(ctx context.Context, tmpBasePath, mergeHeadSHA, mergeBaseSHA string | |||
// 6. Take the output of cat-file --batch and check if each file in turn | |||
// to see if they're pointers to files in the LFS store associated with | |||
// the head repo and add them to the base repo if so | |||
go createLFSMetaObjectsFromCatFileBatch(catFileBatchReader, &wg, pr) | |||
go createLFSMetaObjectsFromCatFileBatch(db.DefaultContext, catFileBatchReader, &wg, pr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why default
if we have a ctx
param?
Suggested change
go createLFSMetaObjectsFromCatFileBatch(db.DefaultContext, catFileBatchReader, &wg, pr) | |
go createLFSMetaObjectsFromCatFileBatch(ctx, catFileBatchReader, &wg, pr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a goroutine, which could cause problems
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Oct 12, 2023
KN4CK3R
approved these changes
Oct 13, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Oct 13, 2023
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Oct 14, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Oct 14, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 16, 2023
* giteaofficial/main: [skip ci] Updated licenses and gitignores Improve retrying index issues (go-gitea#27554) Replace more db.DefaultContext (go-gitea#27628) Fix 404 when there is an internal version of package (go-gitea#27615) [skip ci] Updated translations via Crowdin Add anchor to review types (go-gitea#26894) Update readme to remove drone svg (go-gitea#27624) Change the default branch in the agit docs (go-gitea#27621) Final round of `db.DefaultContext` refactor (go-gitea#27587) Fix permissions for Token DELETE endpoint to match GET and POST (go-gitea#27610) Enhanced auth token / remember me (go-gitea#27606) [skip ci] Updated translations via Crowdin rm outdated docs from some languages (go-gitea#27530) Upgrade go dependencies (go-gitea#27599) Fix build errors on BSD (in BSDMakefile) (go-gitea#27594) Enable shorthands in `declaration-strict-value` linter (go-gitea#27597) [skip ci] Updated translations via Crowdin Make disk clean action a bit more robust (go-gitea#27590)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/api
This PR adds API routes or modifies them
modifies/cli
PR changes something on the CLI, i.e. gitea doctor or gitea admin
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last part of #27065