Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 404 when deleting Docker package with an internal version #27615

Merged
merged 2 commits into from
Oct 15, 2023

Conversation

lng2020
Copy link
Member

@lng2020 lng2020 commented Oct 14, 2023

close #27601
The Docker registry has an internal version, which leads to 404

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 14, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 14, 2023
@lunny lunny requested a review from KN4CK3R October 15, 2023 01:57
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 15, 2023
@KN4CK3R KN4CK3R enabled auto-merge (squash) October 15, 2023 08:50
@delvh
Copy link
Member

delvh commented Oct 15, 2023

Backport 1.21?

@KN4CK3R
Copy link
Member

KN4CK3R commented Oct 15, 2023

Yes, was just looking if this in 1.21, and yes it is.

@KN4CK3R KN4CK3R added the backport/v1.21 This PR should be backported to Gitea 1.21 label Oct 15, 2023
@delvh delvh changed the title Fix 404 when there is an internal version of package Fix 404 when deleting Docker package with an internal version Oct 15, 2023
@KN4CK3R KN4CK3R added the backport/v1.20 This PR should be backported to Gitea 1.20 label Oct 15, 2023
@KN4CK3R KN4CK3R merged commit 7480aac into go-gitea:main Oct 15, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Oct 15, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 15, 2023
close go-gitea#27601
The Docker registry has an internal version, which leads to 404
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 15, 2023
close go-gitea#27601
The Docker registry has an internal version, which leads to 404
KN4CK3R pushed a commit that referenced this pull request Oct 15, 2023
#27629)

Backport #27615 by @lng2020

close #27601
The Docker registry has an internal version, which leads to 404

Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
KN4CK3R pushed a commit that referenced this pull request Oct 15, 2023
#27630)

Backport #27615 by @lng2020

close #27601
The Docker registry has an internal version, which leads to 404

Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com>
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.20. @lng2020, please send one manually. 🍵

go run ./contrib/backport 27615
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Oct 15, 2023
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.21. @lng2020, please send one manually. 🍵

go run ./contrib/backport 27615
...  // fix git conflicts if any
go run ./contrib/backport --continue

@lunny lunny added the backport/done All backports for this PR have been created label Oct 16, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 16, 2023
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Improve retrying index issues (go-gitea#27554)
  Replace more db.DefaultContext (go-gitea#27628)
  Fix 404 when there is an internal version of package (go-gitea#27615)
  [skip ci] Updated translations via Crowdin
  Add anchor to review types (go-gitea#26894)
  Update readme to remove drone svg (go-gitea#27624)
  Change the default branch in the agit docs (go-gitea#27621)
  Final round of `db.DefaultContext` refactor (go-gitea#27587)
  Fix permissions for Token DELETE endpoint to match GET and POST (go-gitea#27610)
  Enhanced auth token / remember me (go-gitea#27606)
  [skip ci] Updated translations via Crowdin
  rm outdated docs from some languages (go-gitea#27530)
  Upgrade go dependencies (go-gitea#27599)
  Fix build errors on BSD (in BSDMakefile) (go-gitea#27594)
  Enable shorthands in `declaration-strict-value` linter (go-gitea#27597)
  [skip ci] Updated translations via Crowdin
  Make disk clean action a bit more robust (go-gitea#27590)
@lng2020 lng2020 deleted the fix-package-404 branch October 21, 2023 03:16
@lng2020 lng2020 removed the backport/manual No power to the bots! Create your backport yourself! label Oct 21, 2023
@lng2020 lng2020 restored the fix-package-404 branch October 21, 2023 03:18
@lng2020 lng2020 deleted the fix-package-404 branch October 21, 2023 03:18
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.20 This PR should be backported to Gitea 1.20 backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/packages type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete container packages 404
5 participants