Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use filepath instead of path to create SQLite3 database file #28374

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Use filepath instead of path to create SQLite3 database file #28374

merged 2 commits into from
Dec 6, 2023

Conversation

wxiaoguang
Copy link
Contributor

Fix #28300

@wxiaoguang wxiaoguang added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Dec 6, 2023
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Dec 6, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 6, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 6, 2023
@wxiaoguang wxiaoguang mentioned this pull request Dec 6, 2023
Closed
delvh
delvh approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how often we'll manage to confuse path and filepath 😁

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 6, 2023
@delvh delvh changed the title Fix incorrect directory path handling for SQLite3 database file Use filepath instead of path to create SQLite3 database file Dec 6, 2023
@JakobDev
Copy link
Contributor

JakobDev commented Dec 6, 2023

Why did this work on Linux but not on Windows?

@techknowlogick
Copy link
Member

@JakobDev as windows uses different slashes that don't always convert when sending the Linux path :(

@JakobDev
Copy link
Contributor

JakobDev commented Dec 6, 2023

as windows uses different slashes

Just a sidenote: Modern Windows versions also support / as path separator, so we don't need to convert anything

@wxiaoguang
Copy link
Contributor Author

Why did this work on Linux but not on Windows?

as windows uses different slashes

Just a sidenote: Modern Windows versions also support / as path separator, so we don't need to convert anything

Golang (Windows): path.Dir("D:\\foo\\bar") => "."

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 6, 2023
@jolheiser jolheiser enabled auto-merge (squash) December 6, 2023 16:33
@jolheiser jolheiser added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 6, 2023
@jolheiser jolheiser merged commit 1e512b8 into go-gitea:main Dec 6, 2023
25 checks passed
@GiteaBot GiteaBot mentioned this pull request Dec 6, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 6, 2023
@wxiaoguang @GiteaBot
Use filepath instead of path to create SQLite3 database file (go-…
01d3da4 
…gitea#28374)
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Dec 6, 2023
jolheiser pushed a commit that referenced this pull request Dec 6, 2023
@GiteaBot
Use filepath instead of path to create SQLite3 database file (#28374
5eaf91e 
) (#28378)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Fix #28300
@wxiaoguang wxiaoguang deleted the fix-sqlite-dir branch December 7, 2023 00:38
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 8, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
13beca8 
* giteaofficial/main:
  Improve text in Security settings (go-gitea#28393)
  Fix Docker meta action for releases (go-gitea#28232)
  Make gogit Repository.GetBranchNames consistent (go-gitea#28348)
  Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (go-gitea#28220)
  Include public repos in doer's dashboard for issue search (go-gitea#28304)
  Issue fixes for RSS feed improvements (go-gitea#28380)
  Fix margin in server signed signature verification view (go-gitea#28379)
  [skip ci] Updated translations via Crowdin
  Fix incorrect run order of action jobs (go-gitea#28367)
  Improve RSS feed icons (go-gitea#28368)
  Use `filepath` instead of `path` to create SQLite3 database file (go-gitea#28374)
  Fix incorrect default value of `[attachment].MAX_SIZE` (go-gitea#28373)
  Fix object does not exist error when checking citation file (go-gitea#28314)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@wxiaoguang @fuxiaohei
Use filepath instead of path to create SQLite3 database file (go-…
9196535 
…gitea#28374)
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@wxiaoguang @silverwind
Use filepath instead of path to create SQLite3 database file (go-…
42e3473 
…gitea#28374)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Unable to open database file: The system cannot find the path specified
6 participants
@wxiaoguang @JakobDev @techknowlogick @jolheiser @delvh @GiteaBot