Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix margin in server signed signature verification view #28379

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Fix margin in server signed signature verification view #28379

merged 3 commits into from
Dec 7, 2023

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Dec 6, 2023

Before:
image

After:
image

@lafriks lafriks added topic/ui Change the appearance of the Gitea UI backport/v1.21 This PR should be backported to Gitea 1.21 labels Dec 6, 2023
@lafriks lafriks added this to the 1.22.0 milestone Dec 6, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 6, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 6, 2023
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Dec 6, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 7, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 7, 2023
@lafriks lafriks enabled auto-merge (squash) December 7, 2023 01:28
@lafriks lafriks merged commit bfacb5c into go-gitea:main Dec 7, 2023
25 checks passed
@GiteaBot GiteaBot mentioned this pull request Dec 7, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 7, 2023
@lafriks @GiteaBot
Fix margin in server signed signature verification view (go-gitea#28379)
8869f86 
Before:

![image](https://github.com/go-gitea/gitea/assets/165205/e2e2256d-03c5-4ab8-8ed9-08ef68571a43)

After:

![image](https://github.com/go-gitea/gitea/assets/165205/804132ef-18f9-4ab8-949d-f6c71e7f4d24)
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Dec 7, 2023
lunny pushed a commit that referenced this pull request Dec 7, 2023
@GiteaBot @lafriks
Fix margin in server signed signature verification view (#28379) (#28381
b56a9f6 
)

Backport #28379 by @lafriks

Before:

![image](https://github.com/go-gitea/gitea/assets/165205/e2e2256d-03c5-4ab8-8ed9-08ef68571a43)

After:

![image](https://github.com/go-gitea/gitea/assets/165205/804132ef-18f9-4ab8-949d-f6c71e7f4d24)

Co-authored-by: Lauris BH <lauris@nix.lv>
@lafriks lafriks deleted the fix/server_signed_margin branch December 7, 2023 10:28
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 8, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
13beca8 
* giteaofficial/main:
  Improve text in Security settings (go-gitea#28393)
  Fix Docker meta action for releases (go-gitea#28232)
  Make gogit Repository.GetBranchNames consistent (go-gitea#28348)
  Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (go-gitea#28220)
  Include public repos in doer's dashboard for issue search (go-gitea#28304)
  Issue fixes for RSS feed improvements (go-gitea#28380)
  Fix margin in server signed signature verification view (go-gitea#28379)
  [skip ci] Updated translations via Crowdin
  Fix incorrect run order of action jobs (go-gitea#28367)
  Improve RSS feed icons (go-gitea#28368)
  Use `filepath` instead of `path` to create SQLite3 database file (go-gitea#28374)
  Fix incorrect default value of `[attachment].MAX_SIZE` (go-gitea#28373)
  Fix object does not exist error when checking citation file (go-gitea#28314)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@lafriks @fuxiaohei
Fix margin in server signed signature verification view (go-gitea#28379)
115a522 
Before:

![image](https://github.com/go-gitea/gitea/assets/165205/e2e2256d-03c5-4ab8-8ed9-08ef68571a43)

After:

![image](https://github.com/go-gitea/gitea/assets/165205/804132ef-18f9-4ab8-949d-f6c71e7f4d24)
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@lafriks @silverwind
Fix margin in server signed signature verification view (go-gitea#28379)
306558e 
Before:

![image](https://github.com/go-gitea/gitea/assets/165205/e2e2256d-03c5-4ab8-8ed9-08ef68571a43)

After:

![image](https://github.com/go-gitea/gitea/assets/165205/804132ef-18f9-4ab8-949d-f6c71e7f4d24)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lafriks @techknowlogick @wxiaoguang @GiteaBot