Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recolor dark theme to blue shade #29283

Merged
merged 9 commits into from
Feb 28, 2024
Merged

Recolor dark theme to blue shade #29283

merged 9 commits into from
Feb 28, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Feb 20, 2024

Now uses the same primary color as light theme. The secondary colors are shifted towards a slightly blue shade. Could maybe desaturate a bit more, but overall I think I'm happy with it.

Fixes: #27097

Screenshot 2024-02-27 at 22 21 46 image

Now uses the same primary color as light theme. The secondary colors are
shifted towards a slightly blue shade.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 20, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 20, 2024
@silverwind silverwind added the type/enhancement An improvement of existing functionality label Feb 20, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 20, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 20, 2024
@denyskon
Copy link
Member

Could we maybe delay this PR a bit for other maintainers to be able to take a look and say their opinion if something still is to be improved here? :) Myself included, as I don't have the time currently 😆

Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just blocking so others have time to take a peek. Feel free to dismiss as needed. 🙂

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Feb 20, 2024
@delvh
Copy link
Member

delvh commented Feb 20, 2024

To me, it sounded like this is only part one of the new theme.
Or did I misunderstand something, @silverwind?

@silverwind
Copy link
Member Author

silverwind commented Feb 20, 2024

No this is all. A recolor from green to blue primary color with adjustment of the secondary colors. Right now primary color matches the light theme, I could see it being darkened slightly as well if it's deemed too bright.

@silverwind
Copy link
Member Author

Will give this a few more minor adjustments like making it slightly darker and desaturating a tiny bit more.

@silverwind silverwind marked this pull request as draft February 22, 2024 04:47
@silverwind silverwind marked this pull request as ready for review February 27, 2024 20:47
@silverwind silverwind marked this pull request as draft February 27, 2024 20:49
@silverwind silverwind marked this pull request as ready for review February 27, 2024 21:01
@silverwind
Copy link
Member Author

Ready again. I desaturated secondary colors by 40%, but it's barely noticeable in the screenshots above which are updated. I then tried to darken these colors by 6%, but the result ended up seemingly too dark.

@silverwind
Copy link
Member Author

Actually there are some small copy paste errors and I will try one more desaturate, WIP shortly.

@silverwind silverwind marked this pull request as draft February 27, 2024 21:08
@silverwind silverwind marked this pull request as ready for review February 27, 2024 21:22
@silverwind
Copy link
Member Author

Reduced by another 30% in saturation, now it looks almost like Discord in terms of secondary color saturation. I like it.

@denyskon
Copy link
Member

I'm not sure about the contrast of those count labels - everything else looks great.

Screenshot_20240227-223135.png

@silverwind
Copy link
Member Author

silverwind commented Feb 27, 2024

I'm not sure about the contrast of those count labels - everything else looks great.

I'm not sure about the contrast of those count labels - everything else looks great.

Screenshot_20240227-223135.png

Still passes AAA contrast testing:

image

@silverwind
Copy link
Member Author

That said, I guess making the text one notch brighter wouldn't hurt, I guess.

@silverwind
Copy link
Member Author

Tweaked those labels a bit, brighter background and text. 7.63:1 text contrast ratio currently:

image

@denyskon denyskon requested a review from jolheiser February 28, 2024 04:16
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Feb 28, 2024
@denyskon denyskon added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 28, 2024
@silverwind silverwind merged commit d557fbc into go-gitea:main Feb 28, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 28, 2024
@silverwind silverwind deleted the dark branch February 28, 2024 10:16
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 28, 2024
@silverwind
Copy link
Member Author

README.md needs some new screenshots, if anyone wants to do those 😉.

@denyskon
Copy link
Member

Also the about.gitea.com website, before someone suggests again that we're selling a proprietary theme :)

zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 29, 2024
* giteaofficial/main: (23 commits)
  Fix wrong test usage of `AppSubURL` (go-gitea#29459)
  Improve contrast on blame timestamp, fix double border (go-gitea#29482)
  Fix/Improve `processWindowErrorEvent` (go-gitea#29407)
  Apply compact padding to small buttons with svg icons (go-gitea#29471)
  Fix counter display number incorrectly displayed on the page (go-gitea#29448)
  Fix incorrect user location link on profile page (go-gitea#29474)
  Fix workflow trigger event bugs (go-gitea#29467)
  Fix URL calculation in clone input box (go-gitea#29470)
  Remove jQuery from the "find file" page (go-gitea#29456)
  Move generate from module to service (go-gitea#29465)
  The job should always run when `if` is `always()` (go-gitea#29464)
  Recolor dark theme to blue shade (go-gitea#29283)
  Let ctx.FormOptionalBool() return optional.Option[bool] (go-gitea#29461)
  Implement actions badge svgs (go-gitea#28102)
  Fix missed return (go-gitea#29450)
  Use tailwind instead of `gt-[wh]-` helper classes (go-gitea#29423)
  Lock issues and pulls faster (go-gitea#29436)
  Allow to change primary email before account activation (go-gitea#29412)
  Update docs about `DEFAULT_ACTIONS_URL` (go-gitea#29442)
  Only use supported sort order for "explore/users" page (go-gitea#29430)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New dark theme and default theme rename
7 participants