-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recolor dark theme to blue shade #29283
Conversation
Now uses the same primary color as light theme. The secondary colors are shifted towards a slightly blue shade.
Could we maybe delay this PR a bit for other maintainers to be able to take a look and say their opinion if something still is to be improved here? :) Myself included, as I don't have the time currently 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just blocking so others have time to take a peek. Feel free to dismiss as needed. 🙂
To me, it sounded like this is only part one of the new theme. |
No this is all. A recolor from green to blue primary color with adjustment of the secondary colors. Right now primary color matches the light theme, I could see it being darkened slightly as well if it's deemed too bright. |
Will give this a few more minor adjustments like making it slightly darker and desaturating a tiny bit more. |
Ready again. I desaturated secondary colors by 40%, but it's barely noticeable in the screenshots above which are updated. I then tried to darken these colors by 6%, but the result ended up seemingly too dark. |
Actually there are some small copy paste errors and I will try one more desaturate, WIP shortly. |
Reduced by another 30% in saturation, now it looks almost like Discord in terms of secondary color saturation. I like it. |
Still passes AAA contrast testing: |
That said, I guess making the text one notch brighter wouldn't hurt, I guess. |
README.md needs some new screenshots, if anyone wants to do those 😉. |
Also the about.gitea.com website, before someone suggests again that we're selling a proprietary theme :) |
* giteaofficial/main: (23 commits) Fix wrong test usage of `AppSubURL` (go-gitea#29459) Improve contrast on blame timestamp, fix double border (go-gitea#29482) Fix/Improve `processWindowErrorEvent` (go-gitea#29407) Apply compact padding to small buttons with svg icons (go-gitea#29471) Fix counter display number incorrectly displayed on the page (go-gitea#29448) Fix incorrect user location link on profile page (go-gitea#29474) Fix workflow trigger event bugs (go-gitea#29467) Fix URL calculation in clone input box (go-gitea#29470) Remove jQuery from the "find file" page (go-gitea#29456) Move generate from module to service (go-gitea#29465) The job should always run when `if` is `always()` (go-gitea#29464) Recolor dark theme to blue shade (go-gitea#29283) Let ctx.FormOptionalBool() return optional.Option[bool] (go-gitea#29461) Implement actions badge svgs (go-gitea#28102) Fix missed return (go-gitea#29450) Use tailwind instead of `gt-[wh]-` helper classes (go-gitea#29423) Lock issues and pulls faster (go-gitea#29436) Allow to change primary email before account activation (go-gitea#29412) Update docs about `DEFAULT_ACTIONS_URL` (go-gitea#29442) Only use supported sort order for "explore/users" page (go-gitea#29430) ...
Now uses the same primary color as light theme. The secondary colors are shifted towards a slightly blue shade. Could maybe desaturate a bit more, but overall I think I'm happy with it.
Fixes: #27097