Fix date rendering by adding <gitea-absolute-date>
#29725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
|
This is using the current naming scheme, not the one from #29400. Likely in that PR or separately, I will do the rename. |
| @@ -0,0 +1,40 @@ | |||
| window.customElements.define('gitea-locale-date', class extends HTMLElement { | |||
There was a problem hiding this comment.
why not extend <relative-time>?
There was a problem hiding this comment.
We aren't replacing https://github.com/github/relative-time-element, we are just adding another custom element to render absolute dates in locale format.
There was a problem hiding this comment.
Oh, and to answer specifically: <relative-time> is not meant to be passed dates, only datetimes. So it's currently unsuitable for the date rendering and I'm not sure whether upstream would accept a date parameter as it would increase internal complexity of the component a lot.
yardenshoham
approved these changes
Mar 12, 2024
GiteaBot
added
lgtm/need 1
|
Backport? |
|
We can try.... |
Yeah, would be good. |
|
I'm open to renaming as well. |
silverwind
commented
Mar 12, 2024
silverwind
changed the title
<gitea-locale-date><gitea-absolute-date>
denyskon
approved these changes
Mar 12, 2024
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
|
Let's see if it backports automatically 😆. |
github-actions
bot
added
modifies/go
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 12, 2024
Alternative to: go-gitea#29698 Fixes: go-gitea#29034 <img width="278" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/12ecd967-2723-410d-8a28-a1b0f41b7bba"> It also fixes a secondary issue that we were showing timestamp tooltips over date, which makes no sense, so these are now gone as well: <img width="284" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/a70432f3-97b6-41e6-b202-b53b76924a66">
GiteaBot
added
backport/done
silverwind
added a commit
that referenced
this pull request
Mar 13, 2024
Backport #29725 by @silverwind Alternative to: #29698 Fixes: #29034 <img width="278" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/12ecd967-2723-410d-8a28-a1b0f41b7bba"> It also fixes a secondary issue that we were showing timestamp tooltips over date, which makes no sense, so these are now gone as well: <img width="284" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/a70432f3-97b6-41e6-b202-b53b76924a66"> Co-authored-by: silverwind <me@silverwind.io>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 13, 2024
* giteaofficial/main: Fix date rendering by adding `<gitea-absolute-date>` (go-gitea#29725) Update to labeler v5 (go-gitea#29721) Update Chroma to v2.13.0 (go-gitea#29732) Highlight archived labels (go-gitea#29680)
|
It broke my timezone (UTC+2) if I set March 29 |
|
Hmm, will need to debug this. You sure your branch is up to date? |
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Mar 13, 2024
* main: fix missed RenderLabel change in card template (go-gitea#29772) Fix incorrect locale Tr for gpg command (go-gitea#29754) Improve a11y document and dropdown item (go-gitea#29753) Improve QueryEscape helper function (go-gitea#29768) Use relative links for commits, mentions, and issues in markdown (go-gitea#29427) Move fork router functions to a standalone file (go-gitea#29756) Configure pinned JS dependencies via updates.config.js (go-gitea#29696) Refactor to use optional.Option for issue index search option (go-gitea#29739) Fix user router possbile panic (go-gitea#29751) Refactor label.IsArchived() (go-gitea#29750) Fix date rendering by adding `<gitea-absolute-date>` (go-gitea#29725) Update to labeler v5 (go-gitea#29721) Update Chroma to v2.13.0 (go-gitea#29732)
|
@yardenshoham try #29804. Note, I'm not convinced the old implementation had bugs but this new one surely won't. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to: #29698
Fixes: #29034
It also fixes a secondary issue that we were showing timestamp tooltips over date, which makes no sense, so these are now gone as well: