-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jQuery class from the image diff #30140
Merged
wxiaoguang
merged 9 commits into
go-gitea:main
from
yardenshoham:imagediff-jquery-class
Mar 29, 2024
Merged
Remove jQuery class from the image diff #30140
wxiaoguang
merged 9 commits into
go-gitea:main
from
yardenshoham:imagediff-jquery-class
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switched from jQuery class functions to plain JavaScript `classList` - Tested the image diff and it works as before Signed-off-by: Yarden Shoham <git@yardenshoham.com>
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Mar 27, 2024
pull-request-size
bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Mar 27, 2024
wxiaoguang
reviewed
Mar 27, 2024
silverwind
reviewed
Mar 27, 2024
silverwind
reviewed
Mar 27, 2024
silverwind
reviewed
Mar 27, 2024
Co-authored-by: silverwind <me@silverwind.io>
pull-request-size
bot
added
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Mar 28, 2024
silverwind
approved these changes
Mar 28, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Mar 28, 2024
yardenshoham
added
the
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
label
Mar 29, 2024
wxiaoguang
reviewed
Mar 29, 2024
wxiaoguang
reviewed
Mar 29, 2024
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
pull-request-size
bot
added
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Mar 29, 2024
wxiaoguang
approved these changes
Mar 29, 2024
GiteaBot
removed
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Mar 29, 2024
GiteaBot
added
the
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
label
Mar 29, 2024
yardenshoham
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Mar 29, 2024
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Mar 29, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 29, 2024
* giteaofficial/main: Remove jQuery class from the image diff (go-gitea#30140)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/js
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classList