Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery class from the image diff #30140

Merged
merged 9 commits into from
Mar 29, 2024
Merged

Remove jQuery class from the image diff #30140

merged 9 commits into from
Mar 29, 2024

Conversation

yardenshoham
Copy link
Member

  • Switched from jQuery class functions to plain JavaScript classList
  • Tested the image diff and it works as before

@yardenshoham
Remove jQuery class from the image diff
e50df48 
- Switched from jQuery class functions to plain JavaScript `classList`
- Tested the image diff and it works as before

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 27, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 27, 2024
yardenshoham and others added 3 commits March 27, 2024 18:35
@yardenshoham @silverwind
Apply suggestions from code review
a867afb 
Co-authored-by: silverwind <me@silverwind.io>
@yardenshoham
Use :scope
f906716
@yardenshoham
Fix this
a59b533
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 28, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 28, 2024
@yardenshoham yardenshoham requested a review from wxiaoguang March 29, 2024 10:44
@yardenshoham yardenshoham added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 29, 2024
@yardenshoham @wxiaoguang
Make it singular
ecb3b1c 
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 29, 2024
@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 29, 2024
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Mar 29, 2024
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 29, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 29, 2024 12:39
@wxiaoguang wxiaoguang merged commit 849eee8 into go-gitea:main Mar 29, 2024
26 checks passed
@wxiaoguang wxiaoguang deleted the imagediff-jquery-class branch March 29, 2024 12:40
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 29, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 29, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 29, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
1ba6108 
* giteaofficial/main:
  Remove jQuery class from the image diff (go-gitea#30140)
@wxiaoguang wxiaoguang mentioned this pull request Apr 25, 2024
Merged
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@yardenshoham @silverwind @wxiaoguang @GiteaBot