Refactor imagediff and fix regression bug #30694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
wxiaoguang
force-pushed
the
fix-image-diff
branch
from
ebdafb1
to
97d2771
Compare
wxiaoguang
added
type/bug
skip-changelog
lunny
approved these changes
Apr 25, 2024
GiteaBot
added
lgtm/need 1
|
Where exactly was the bug? |
|
silverwind
reviewed
Apr 25, 2024
Co-authored-by: silverwind <me@silverwind.io>
In the issue's screenshot #30683 (comment)
|
silverwind
approved these changes
Apr 25, 2024
GiteaBot
added
lgtm/done
|
So the bug was basically a missed check if a queried element existed? |
wxiaoguang
commented
Apr 25, 2024
I think so. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 26, 2024
* giteaofficial/main: Deduplicate lfs common code (go-gitea#30704) Improve job commit description (go-gitea#30579) Improve test for TestPullCompare (go-gitea#30699) Allow to save empty comment (go-gitea#30706) [skip ci] Updated translations via Crowdin Refactor imagediff and fix regression bug (go-gitea#30694) Improve oauth2 client "preferred username field" logic and the error handling (go-gitea#30622) Fix active item in tab menu (go-gitea#30690)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #30683
Regression of #30140