Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test for TestPullCompare #30699

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Improve test for TestPullCompare #30699

merged 2 commits into from
Apr 26, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 25, 2024

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 25, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 25, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 25, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 25, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 25, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 26, 2024
@lunny lunny enabled auto-merge (squash) April 26, 2024 01:24
@lunny lunny merged commit 2a6418a into go-gitea:main Apr 26, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 26, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 26, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 26, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a31d1b3 
* giteaofficial/main:
  Deduplicate lfs common code (go-gitea#30704)
  Improve job commit description (go-gitea#30579)
  Improve test for TestPullCompare (go-gitea#30699)
  Allow to save empty comment (go-gitea#30706)
  [skip ci] Updated translations via Crowdin
  Refactor imagediff and fix regression bug (go-gitea#30694)
  Improve oauth2 client "preferred username field" logic and the error handling (go-gitea#30622)
  Fix active item in tab menu (go-gitea#30690)
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
@yp05327 yp05327 mentioned this pull request May 9, 2024
Closed
@lunny lunny deleted the lunny/improve_test branch May 9, 2024 06:43
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/testing
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @silverwind @wxiaoguang @GiteaBot