Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and fix archive link bug #30535

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Refactor and fix archive link bug #30535

merged 2 commits into from
Apr 18, 2024

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Apr 17, 2024 •
edited by silverwind
Loading

Regression of #29920
Fixes: #30569

Also this is a rewriting to eliminate the remaining jQuery usages from code.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 17, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 17, 2024
@wxiaoguang wxiaoguang changed the title Refactoring and fix archive link bug Refactor and fix archive link bug Apr 17, 2024
@wxiaoguang
Copy link
Contributor Author

I have fully tested related changes:

  1. archive link in a dropdown
  2. archive link without a dropdown
  3. network error

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 17, 2024
@wxiaoguang wxiaoguang mentioned this pull request Apr 17, 2024
Merged
@silverwind
Copy link
Member

BTW, what was the regression?

@wxiaoguang
Copy link
Contributor Author

BTW, what was the regression?

I have posted the problem in this comment: #30506 (comment)

@silverwind
Copy link
Member

Ah I see, I wasn't aware of that button on the release page.

@silverwind silverwind added the backport/v1.22 This PR should be backported to Gitea 1.22 label Apr 17, 2024
silverwind
silverwind reviewed Apr 17, 2024
View reviewed changes
web_src/js/utils/dom.js Outdated Show resolved Hide resolved
wxiaoguang
wxiaoguang commented Apr 17, 2024
View reviewed changes
web_src/js/utils/dom.js Outdated Show resolved Hide resolved
@silverwind
Copy link
Member

silverwind commented Apr 17, 2024 •
edited
Loading

Another problem with callback is that you can not serialize the execution with await involved:

queryElems('a', async () => {
  await fetch();
});

This will and can only run in parallel. It's another reason why I don't like callbacks in general and avoid them wherever possible.

Not a problem with these click handlers, but in other code, it may as well become a problem.

@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Apr 18, 2024 •
edited
Loading

This will and can only run in parallel. It's another reason why I don't like callbacks in general and avoid them wherever possible.

Not a problem with these click handlers, but in other code, it may as well become a problem.

Developers should know what they are writing and doing. For example, there were a lot of "async event listeners" which call "preventDefault" after await in old code, I fixed them one by one, that's why I don't like using async for event listeners, but we are still using them (and more and more)

I do not see any real bad case for using it like this for such code.

@wxiaoguang
Copy link
Contributor Author

Fully rewritten

@wxiaoguang wxiaoguang requested review from silverwind and delvh April 18, 2024 08:19
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Apr 18, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 18, 2024
@silverwind silverwind enabled auto-merge (squash) April 18, 2024 15:25
@silverwind silverwind self-requested a review April 18, 2024 15:27
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Apr 18, 2024
@silverwind silverwind disabled auto-merge April 18, 2024 15:27
@silverwind silverwind removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 18, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 18, 2024
@silverwind silverwind added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Apr 18, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) April 18, 2024 15:48
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 18, 2024
@wxiaoguang wxiaoguang merged commit d0e0708 into go-gitea:main Apr 18, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 18, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 18, 2024
GiteaBot added a commit to GiteaBot/gitea that referenced this pull request Apr 18, 2024
@wxiaoguang @GiteaBot
Refactor and fix archive link bug (go-gitea#30535)
3b018ee 
Regression of go-gitea#29920
Fixes: go-gitea#30569

Also this is a rewriting to eliminate the remaining jQuery usages from code.

Co-authored-by: Giteabot <teabot@gitea.io>
@GiteaBot GiteaBot mentioned this pull request Apr 18, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 18, 2024
@wxiaoguang wxiaoguang deleted the fix-archive-link branch April 19, 2024 01:25
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 19, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
f3b81c7 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Mock queue backoff duration (go-gitea#30553)
  Improve "Reference in new issue" modal (go-gitea#30547)
  Add a few root files to lint-spell (go-gitea#30530)
  Refactor and fix archive link bug (go-gitea#30535)
  Fixup app.example.ini for task section, which is now queue.task (go-gitea#30555)
  Some following up changes for routes (go-gitea#30550)
  Add form field id generation, remove duplicated ids (go-gitea#30546)
  Fix border-radius on view, blame and code search (go-gitea#30545)
  Disable enter key for accepting code completion in Monaco (go-gitea#30548)
silverwind added a commit that referenced this pull request Apr 21, 2024
@GiteaBot @wxiaoguang @silverwind
Refactor and fix archive link bug (#30535) (#30570)
fc376c8 
Backport #30535 by wxiaoguang

Regression of #29920
Fixes: #30569

Also this is a rewriting to eliminate the remaining jQuery usages from
code.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

@delvh delvh Awaiting requested review from delvh

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.23.0
5 participants
@wxiaoguang @silverwind @lunny @delvh @GiteaBot