Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update misspell to 0.5.1 and add misspellings.csv #30573

Merged
merged 9 commits into from
Apr 27, 2024
Merged

Update misspell to 0.5.1 and add misspellings.csv #30573

merged 9 commits into from
Apr 27, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 18, 2024 •
edited
Loading

Misspell 0.5.0 supports passing a csv file to extend the list of misspellings, so I added some common ones from the codebase. There is at least one typo in a API response so we need to decided whether to revert that and then likely remove the dict entry.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 18, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 18, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/docs modifies/migrations modifies/internal modifies/js labels Apr 18, 2024
@silverwind silverwind mentioned this pull request Apr 18, 2024
Closed
@silverwind
Copy link
Member Author

The committer issue looks like a bug in misspell, filed golangci/misspell#18.

@silverwind silverwind changed the title Update misspell to 0.5.0 and add typos.csv Update misspell to 0.5.0 and add misspellings.csv Apr 18, 2024
@silverwind silverwind marked this pull request as draft April 19, 2024 00:30
@silverwind silverwind marked this pull request as ready for review April 21, 2024 20:26
@silverwind
Copy link
Member Author

Should be ready now, the API change was reverted and the word "comiter" removed from the list of words. The only other potentially problematic change is the struct change for Reviwer property, but it seems it's not exposed externally.

lunny
lunny reviewed Apr 22, 2024
View reviewed changes
assets/misspellings.csv Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 24, 2024
@silverwind silverwind changed the title Update misspell to 0.5.0 and add misspellings.csv Update misspell to 0.5.1 and add misspellings.csv Apr 26, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 27, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) April 27, 2024 07:36
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 27, 2024
@techknowlogick techknowlogick merged commit 9b2536b into go-gitea:main Apr 27, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 27, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 27, 2024
@silverwind silverwind deleted the misspell050 branch April 27, 2024 09:44
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 27, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
289aed7 
* giteaofficial/main:
  Make Ctrl+Enter work for issue/comment edit (go-gitea#30720)
  Rename migration package name for 1.22-rc1 (go-gitea#30730)
  Issue card improvements (go-gitea#30687)
  Don't show loading indicators when refreshing the system status (go-gitea#30712)
  Add some tests to clarify the "must-change-password" behavior (go-gitea#30693)
  Prevent allow/reject reviews on merged/closed PRs (go-gitea#30686)
  Update JS dependencies (go-gitea#30713)
  Improve diff stats bar (go-gitea#30669)
  Remove unused parameter for some functions in `services/mirror` (go-gitea#30724)
  Update misspell to 0.5.1 and add `misspellings.csv` (go-gitea#30573)
  Suppress browserslist warning in webpack target (go-gitea#30571)
  [skip ci] Updated translations via Crowdin
  Diff color enhancements, add line number background (go-gitea#30670)
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 27, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into noext
d98bdfc 
* origin/main:
  Replace deprecated `math/rand` functions (go-gitea#30733)
  Make Ctrl+Enter work for issue/comment edit (go-gitea#30720)
  Rename migration package name for 1.22-rc1 (go-gitea#30730)
  Issue card improvements (go-gitea#30687)
  Don't show loading indicators when refreshing the system status (go-gitea#30712)
  Add some tests to clarify the "must-change-password" behavior (go-gitea#30693)
  Prevent allow/reject reviews on merged/closed PRs (go-gitea#30686)
  Update JS dependencies (go-gitea#30713)
  Improve diff stats bar (go-gitea#30669)
  Remove unused parameter for some functions in `services/mirror` (go-gitea#30724)
  Update misspell to 0.5.1 and add `misspellings.csv` (go-gitea#30573)
  Suppress browserslist warning in webpack target (go-gitea#30571)
  [skip ci] Updated translations via Crowdin
  Diff color enhancements, add line number background (go-gitea#30670)
  feat(api): enhance Actions Secrets Management API for repository (go-gitea#30656)
  Fix code search input for different views (go-gitea#30678)
  Fix incorrect object id hash function (go-gitea#30708)
@yp05327 yp05327 mentioned this pull request May 8, 2024
Merged
lunny pushed a commit that referenced this pull request May 8, 2024
@yp05327
Fix misspelling of mergable (#30896)
f7d2f69 
#25812 (comment)
Follow #30573
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 8, 2024
@yp05327 @GiteaBot
Fix misspelling of mergable (go-gitea#30896)
dd73cb9 
go-gitea#25812 (comment)
Follow go-gitea#30573
@GiteaBot GiteaBot mentioned this pull request May 8, 2024
Merged
techknowlogick pushed a commit that referenced this pull request May 8, 2024
@GiteaBot @yp05327
Fix misspelling of mergable (#30896) (#30905)
2f91a46 
Backport #30896 by @yp05327

#25812 (comment)
Follow #30573

Co-authored-by: yp05327 <576951401@qq.com>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/docs modifies/go Pull requests that update Go code modifies/internal modifies/js modifies/migrations size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @lunny @techknowlogick @wxiaoguang @GiteaBot