Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Ctrl+Enter work for issue/comment edit #30720

Merged
merged 2 commits into from
Apr 27, 2024
Merged

Make Ctrl+Enter work for issue/comment edit #30720

merged 2 commits into from
Apr 27, 2024

Conversation

wxiaoguang
Copy link
Contributor

Fix #30710

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 26, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 26, 2024
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/js labels Apr 26, 2024
@wxiaoguang wxiaoguang mentioned this pull request Apr 26, 2024
Closed
@bilogic
Copy link
Contributor

bilogic commented Apr 26, 2024 •
edited
Loading

came from #30710, cheering for the quick fix to go into nightly :)

@silverwind
Copy link
Member

<div class="ui form"> is an abuse, they should be <form class="ui form"> but I see the abuse is extensive, a quick search shows 35 matches.

silverwind
silverwind approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok as a short-term fix. long-term we should fix those forms to be <form>.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 26, 2024
@wxiaoguang
Copy link
Contributor Author

<div class="ui form"> is an abuse, they should be <form class="ui form"> but I see the abuse is extensive, a quick search shows 35 matches.

No, it isn't if you are familiar with Fomantic UI

image

@silverwind
Copy link
Member

<div class="ui form"> is an abuse, they should be <form class="ui form"> but I see the abuse is extensive, a quick search shows 35 matches.

No, it isn't if you are familiar with Fomantic UI

I see, but it would still be desirable to change to <form>, right?

@wxiaoguang
Copy link
Contributor Author

I see, but it would still be desirable to change to <form>, right?

I think for most AJAX cases, it's better not to use <form>. Maybe we could leave this problem for the future.

@silverwind
Copy link
Member

silverwind commented Apr 27, 2024 •
edited
Loading

AJAX-submitted forms need to preventDefault() the submit event, but yes, something for later.

@wxiaoguang wxiaoguang requested a review from lunny April 27, 2024 11:48
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 27, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 27, 2024
@lunny lunny enabled auto-merge (squash) April 27, 2024 14:04
@lunny lunny merged commit 8de2992 into go-gitea:main Apr 27, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 27, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 27, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 27, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
289aed7 
* giteaofficial/main:
  Make Ctrl+Enter work for issue/comment edit (go-gitea#30720)
  Rename migration package name for 1.22-rc1 (go-gitea#30730)
  Issue card improvements (go-gitea#30687)
  Don't show loading indicators when refreshing the system status (go-gitea#30712)
  Add some tests to clarify the "must-change-password" behavior (go-gitea#30693)
  Prevent allow/reject reviews on merged/closed PRs (go-gitea#30686)
  Update JS dependencies (go-gitea#30713)
  Improve diff stats bar (go-gitea#30669)
  Remove unused parameter for some functions in `services/mirror` (go-gitea#30724)
  Update misspell to 0.5.1 and add `misspellings.csv` (go-gitea#30573)
  Suppress browserslist warning in webpack target (go-gitea#30571)
  [skip ci] Updated translations via Crowdin
  Diff color enhancements, add line number background (go-gitea#30670)
@wxiaoguang wxiaoguang deleted the fix-comment-edit-submit branch April 27, 2024 14:51
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 27, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into noext
d98bdfc 
* origin/main:
  Replace deprecated `math/rand` functions (go-gitea#30733)
  Make Ctrl+Enter work for issue/comment edit (go-gitea#30720)
  Rename migration package name for 1.22-rc1 (go-gitea#30730)
  Issue card improvements (go-gitea#30687)
  Don't show loading indicators when refreshing the system status (go-gitea#30712)
  Add some tests to clarify the "must-change-password" behavior (go-gitea#30693)
  Prevent allow/reject reviews on merged/closed PRs (go-gitea#30686)
  Update JS dependencies (go-gitea#30713)
  Improve diff stats bar (go-gitea#30669)
  Remove unused parameter for some functions in `services/mirror` (go-gitea#30724)
  Update misspell to 0.5.1 and add `misspellings.csv` (go-gitea#30573)
  Suppress browserslist warning in webpack target (go-gitea#30571)
  [skip ci] Updated translations via Crowdin
  Diff color enhancements, add line number background (go-gitea#30670)
  feat(api): enhance Actions Secrets Management API for repository (go-gitea#30656)
  Fix code search input for different views (go-gitea#30678)
  Fix incorrect object id hash function (go-gitea#30708)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Ctrl+Enter works when creating but not when updating a comment
5 participants
@wxiaoguang @bilogic @silverwind @lunny @GiteaBot