Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add must-change-password flag to cli for creating a user #4955

Merged
merged 9 commits into from
Oct 20, 2018
Merged

Add must-change-password flag to cli for creating a user #4955

merged 9 commits into from
Oct 20, 2018

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Sep 18, 2018

This is more like an addition to #4489 .. This introduces a flag that mimics the aforementioned PR.

@jonasfranz jonasfranz added the type/enhancement An improvement of existing functionality label Sep 18, 2018
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 18, 2018
@jonasfranz jonasfranz added this to the 1.7.0 milestone Sep 18, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 18, 2018
lafriks
lafriks requested changes Sep 18, 2018
View reviewed changes
cmd/admin.go Outdated
@@ -59,6 +59,11 @@ var (
Value: "custom/conf/app.ini",
Usage: "Custom configuration file path",
},
cli.StringFlag{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be cli.BoolFlag. Also why default to false if from UI default is true?

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@552d8d3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #4955   +/-   ##
========================================
  Coverage          ?   37.4%           
========================================
  Files             ?     306           
  Lines             ?   45334           
  Branches          ?       0           
========================================
  Hits              ?   16956           
  Misses            ?   25924           
  Partials          ?    2454

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 552d8d3...d2bc4de. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Sep 18, 2018 •
edited
Loading

Codecov Report

Merging #4955 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4955   +/-   ##
=======================================
  Coverage   37.39%   37.39%           
=======================================
  Files         308      308           
  Lines       45612    45612           
=======================================
  Hits        17057    17057           
- Misses      26096    26097    +1     
+ Partials     2459     2458    -1
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_indexer.go 52.11% <0%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a4648c...c63ca0a. Read the comment docs.

@adelowo adelowo force-pushed the must_change_password_cli branch from bccdb4d to ddced41 Compare October 6, 2018 10:39
@lunny
Copy link
Member

lunny commented Oct 18, 2018

@lafriks need your approval.

@lafriks lafriks merged commit c2748ea into go-gitea:master Oct 20, 2018
@adelowo adelowo deleted the must_change_password_cli branch October 20, 2018 22:20
@adelowo adelowo mentioned this pull request Nov 23, 2018
Closed
6 tasks
@adelowo adelowo mentioned this pull request Jan 9, 2019
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonasfranz jonasfranz jonasfranz approved these changes

@sapk sapk sapk approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
7 participants
@adelowo @codecov-io @lunny @lafriks @sapk @jonasfranz @bkcsoft