Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add must-change-password flag to cli for creating a user #4955

Merged
merged 9 commits into from
Oct 20, 2018
Merged

Add must-change-password flag to cli for creating a user #4955

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e6827d4
add support for an admin to force a user to change his/her password f…
adelowo Sep 18, 2018
938d1f7
use BoolFlag instead
adelowo Sep 18, 2018
d2bc4de
default to true
adelowo Sep 18, 2018
c104e50
Merge remote-tracking branch 'origin/master' into must_change_passwor…
adelowo Oct 6, 2018
ddced41
simplify by removing unnneccessary if/else
adelowo Oct 6, 2018
5c075a5
Merge branch 'master' into must_change_password_cli
lunny Oct 18, 2018
10b8ffc
Merge branch 'master' into must_change_password_cli
lafriks Oct 19, 2018
f49a4d5
Merge branch 'master' into must_change_password_cli
adelowo Oct 19, 2018
c63ca0a
Merge branch 'master' into must_change_password_cli
lafriks Oct 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions cmd/admin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ var (
Value: "custom/conf/app.ini",
Usage: "Custom configuration file path",
},
cli.StringFlag{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be cli.BoolFlag. Also why default to false if from UI default is true?

Name: "must-change-password",
Value: "false",
Usage: "Force the user to change his/her password after initial login",
},
},
}

Expand Down Expand Up @@ -286,11 +291,12 @@ func runCreateUser(c *cli.Context) error {
}

if err := models.CreateUser(&models.User{
Name: c.String("name"),
Email: c.String("email"),
Passwd: c.String("password"),
IsActive: true,
IsAdmin: c.Bool("admin"),
Name: c.String("name"),
Email: c.String("email"),
Passwd: c.String("password"),
IsActive: true,
IsAdmin: c.Bool("admin"),
MustChangePassword: c.Bool("must-change-password"),
}); err != nil {
return fmt.Errorf("CreateUser: %v", err)
}
Expand Down