Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove version string from main (make take care of it) #8686

Closed
wants to merge 5 commits into from

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 25, 2019

No description provided.

main.go Outdated
@@ -29,7 +29,7 @@ import (

var (
// Version holds the current Gitea version
Version = "1.9.0-dev"
Version = ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps instead:

Suggested change
Version = ""
Version = "0.0.0-dev"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ?

the other variablen (Tags, MakeVersion, ...) are empty too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@techknowlogick should we fill them up with dummy strings too ?!?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is here so there would be version string if built without make

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 25, 2019
@codecov-io
Copy link

codecov-io commented Oct 25, 2019

Codecov Report

Merging #8686 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8686      +/-   ##
==========================================
- Coverage   41.23%   41.22%   -0.02%     
==========================================
  Files         544      544              
  Lines       70002    70002              
==========================================
- Hits        28866    28858       -8     
- Misses      37447    37449       +2     
- Partials     3689     3695       +6
Impacted Files Coverage Δ
modules/sync/unique_queue.go 78.57% <0%> (-10.72%) ⬇️
modules/process/manager.go 78.37% <0%> (-4.06%) ⬇️
modules/migrations/migrate.go 21.22% <0%> (-1.68%) ⬇️
modules/migrations/gitea.go 10.16% <0%> (-1.49%) ⬇️
models/repo.go 48.81% <0%> (-0.06%) ⬇️
models/error.go 32.98% <0%> (+1.23%) ⬆️
modules/task/migrate.go 28.2% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b747501...b7757f8. Read the comment docs.

Co-Authored-By: techknowlogick <matti@mdranta.net>
@6543
Copy link
Member Author

6543 commented Oct 25, 2019

@techknowlogick @lafriks done

@lunny
Copy link
Member

lunny commented Oct 26, 2019

Why change it?

@6543
Copy link
Member Author

6543 commented Oct 26, 2019

@lunny
was just iritated and thoungt we should either update it or leave it blak, lafriks pointed out we shuld put something in it and techknowlogick had the value :)

so this smal diff got lot attention :O

@6543
Copy link
Member Author

6543 commented Oct 26, 2019

  • normaly i do code format and kind of this with other PR but this one changes main.go ...

@6543 6543 closed this Nov 8, 2019
@6543 6543 deleted the wrong-version branch