-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove version string from main (make take care of it) #8686
Conversation
main.go
Outdated
@@ -29,7 +29,7 @@ import ( | |||
|
|||
var ( | |||
// Version holds the current Gitea version | |||
Version = "1.9.0-dev" | |||
Version = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps instead:
Version = "" | |
Version = "0.0.0-dev" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ?
the other variablen (Tags, MakeVersion, ...) are empty too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@techknowlogick should we fill them up with dummy strings too ?!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is here so there would be version string if built without make
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Codecov Report
@@ Coverage Diff @@
## master #8686 +/- ##
==========================================
- Coverage 41.23% 41.22% -0.02%
==========================================
Files 544 544
Lines 70002 70002
==========================================
- Hits 28866 28858 -8
- Misses 37447 37449 +2
- Partials 3689 3695 +6
Continue to review full report at Codecov.
|
Co-Authored-By: techknowlogick <matti@mdranta.net>
@techknowlogick @lafriks done |
Why change it? |
@lunny so this smal diff got lot attention :O |
|
No description provided.