Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove version string from main (make take care of it) #8686

Closed
wants to merge 5 commits into from
Closed

remove version string from main (make take care of it) #8686

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
785e1e8
remove version string from main (make take care of it)
6543 Oct 25, 2019
5225a7a
add dummy version string to main.go
6543 Oct 25, 2019
e94ae40
make CI work again
6543 Oct 25, 2019
07403b3
Merge branch 'master' into wrong-version
6543 Oct 28, 2019
b7757f8
Merge branch 'master' into wrong-version
6543 Nov 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import (

var (
// Version holds the current Gitea version
Version = "1.9.0-dev"
Version = ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps instead:

Suggested change
Version = ""
Version = "0.0.0-dev"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ?

the other variablen (Tags, MakeVersion, ...) are empty too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@techknowlogick should we fill them up with dummy strings too ?!?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is here so there would be version string if built without make

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

// Tags holds the build tags used
Tags = ""
// MakeVersion holds the current Make version if built with make
Expand Down