fix(contrib): get nacos service of customize group name #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
registry.GetService调用了nacos-sdk-go包中的SelectInstances方法：
···
func (sc *NamingClient) SelectInstances(param vo.SelectInstancesParam) ([]model.Instance, error) {
if len(param.GroupName) == 0 {
param.GroupName = constant.DEFAULT_GROUP
}
.......
}
···
如果没有指定param.GroupName,则取默认的分组名称。目前kratos的实现中，registry.GetService接口参数签名，只支持serviceName，所以无法获取自定义分组名称的服务。为了支持这种情况，加了字符串分隔。跟官方保持一致，分隔符采用“@@”.
修改之后，业务中这样调用：
//GroupName为自定义的分组名称
registry.GetService(ctx, "GroupName@@ServiceName")
//默认的分组名称
registry.GetService(ctx, "ServiceName")
JinPengCN
changed the title
JinPengCN
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1798 +/- ##
=======================================
Coverage 80.80% 80.80%
=======================================
Files 80 80
Lines 3558 3558
=======================================
Hits 2875 2875
Misses 477 477
Partials 206 206 Continue to review full report at Codecov.
|
JinPengCN
changed the title
JinPengCN
changed the title
Nacos service need the custom group support
tonybase
reviewed
Feb 18, 2022
tonybase
reviewed
Feb 19, 2022
Nacos service need the custom group support fix(crntrib): add the splitServiceNameNum constant deps:upgrade go mod version (go-kratos#1800) * deps:upgrade go mod version fix: allocates new objects each time (go-kratos#1802) fix: fix ci tool (go-kratos#1803) * fix: fix ci tool fix(crntrib): add the splitServiceNameSep constant fix(crntrib): get GroupName from opts fix(crntrib): get GroupName from opts fix(crntrib): get GroupName from opts Update registry.go
tonybase
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (what this PR does / why we need it):
registry.GetService调用了nacos-sdk-go包中的SelectInstances方法：
···
func (sc *NamingClient) SelectInstances(param vo.SelectInstancesParam) ([]model.Instance, error) {
if len(param.GroupName) == 0 {
param.GroupName = constant.DEFAULT_GROUP
}
.......
}
···
如果没有指定param.GroupName,则取默认的分组名称。目前kratos的实现中，registry.GetService方法中只设置了ServiceName，所以无法获取自定义分组名称的服务。为了支持这种情况，增加GroupName参数的设置。
Which issue(s) this PR fixes (resolves / be part of):
fixes #1801
Other special notes for reviewer: