Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contrib): get nacos service of customize group name #1798

Merged
merged 13 commits into from
Feb 22, 2022
Merged

fix(contrib): get nacos service of customize group name #1798

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8e2e5a2
获取nacos注册的服务，支持自定义分组
JinPengCN Jan 28, 2022
23107c7
Update watcher.go
JinPengCN Jan 28, 2022
d1aa8b7
Update watcher.go
JinPengCN Jan 28, 2022
8421310
fix(crontrib): add the custom group support
JinPengCN Jan 28, 2022
eb8de43
fix(crntrib): add the splitServiceNameNum constant
JinPengCN Jan 28, 2022
ff2d1ea
Merge branch 'main' into patch-1
JinPengCN Feb 7, 2022
218152f
fix(crntrib): add the splitServiceNameSep constant
JinPengCN Feb 7, 2022
fee4773
fix(crntrib): get GroupName from opts
JinPengCN Feb 18, 2022
0b0a62a
fix(crntrib): get GroupName from opts
JinPengCN Feb 18, 2022
c26e420
fix(crntrib): get GroupName from opts
JinPengCN Feb 18, 2022
3b3ac52
Update registry.go
JinPengCN Feb 19, 2022
a9366b0
fix(contrib): add the custom group support
JinPengCN Jan 28, 2022
e8e295c
Merge branch 'patch-1' of https://github.com/JinPengCN/kratos into pa…
JinPengCN Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion contrib/registry/nacos/registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"strconv"

"github.com/nacos-group/nacos-sdk-go/clients/naming_client"
"github.com/nacos-group/nacos-sdk-go/common/constant"
"github.com/nacos-group/nacos-sdk-go/vo"

"github.com/go-kratos/kratos/v2/registry"
Expand Down Expand Up @@ -65,7 +66,7 @@ func New(cli naming_client.INamingClient, opts ...Option) (r *Registry) {
op := options{
prefix: "/microservices",
cluster: "DEFAULT",
group: "DEFAULT_GROUP",
group: constant.DEFAULT_GROUP,
weight: 100,
kind: "grpc",
}
Expand Down Expand Up @@ -167,6 +168,7 @@ func (r *Registry) Watch(ctx context.Context, serviceName string) (registry.Watc
func (r *Registry) GetService(_ context.Context, serviceName string) ([]*registry.ServiceInstance, error) {
res, err := r.cli.SelectInstances(vo.SelectInstancesParam{
ServiceName: serviceName,
GroupName: r.opts.group,
HealthyOnly: true,
})
if err != nil {
Expand Down